Using some builds the modular build fails due to missing exports
and includes. This fixes the build.
Details
Details
- Reviewers
ldionne - Group Reviewers
Restricted Project - Commits
- rG9c8f3409494f: [libc++][format] Fixes test failures.
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
Comment Actions
Most of the additions seem correct, but I don't understand a few of them. I'd like to understand to make sure we're not just blindly adding includes to fix stuff (and to fix what?).
libcxx/test/std/utilities/format/format.formatter/format.parse.ctx/check_arg_id.verify.cpp | ||
---|---|---|
15–16 | Why is this needed? What is this fixing? | |
libcxx/test/std/utilities/format/format.functions/ascii.pass.cpp | ||
20 | We're not using std::string here right? Why is this needed? |
Why is this needed? What is this fixing?