This is an archive of the discontinued LLVM Phabricator instance.

[libc++] Look for Clang 17 when compiling clang-tidy checks
ClosedPublic

Authored by philnik on Jan 31 2023, 4:05 AM.

Details

Summary

This allows compiling the clang-tidy checks when you only have ToT clang

Diff Detail

Event Timeline

philnik created this revision.Jan 31 2023, 4:05 AM
Herald added a project: Restricted Project. · View Herald TranscriptJan 31 2023, 4:05 AM
philnik requested review of this revision.Jan 31 2023, 4:05 AM
Herald added a project: Restricted Project. · View Herald TranscriptJan 31 2023, 4:05 AM
Herald added a reviewer: Restricted Project. · View Herald Transcript
ldionne accepted this revision.Feb 1 2023, 9:12 AM
ldionne added inline comments.
libcxx/test/tools/clang_tidy_checks/CMakeLists.txt
6–7

This is supported starting in CMake 3.19, and starting with LLVM 17 we support CMake >= 3.20.

This revision is now accepted and ready to land.Feb 1 2023, 9:12 AM
philnik updated this revision to Diff 493996.Feb 1 2023, 9:53 AM
philnik marked an inline comment as done.

Address comments