This is an archive of the discontinued LLVM Phabricator instance.

Differential D142951

[libc++][ranges] Fix incorrect integer typedef in `elements_view` test.
ClosedPublic

Authored by var-const on Jan 30 2023, 7:47 PM.

Details

Reviewers
philnik
ldionne
Group Reviewers
Restricted Project
Commits
rG3fe3f9c51cba: [libc++][ranges] Fix incorrect integer typedef in `elements_view` test.

Diff Detail

Unit TestsFailed

TimeTest
1,499,970 mslibcxx CI Apple back-deployment macosx10.15 > apple-libc++-backdeployment-cfg-in.std/thread/thread_condition::notify_all_at_thread_exit_lwg3343.pass.cpp
1,499,900 mslibcxx CI Apple back-deployment macosx11.0 arm64 > apple-libc++-backdeployment-cfg-in.std/thread/thread_condition::notify_all_at_thread_exit_lwg3343.pass.cpp

Event Timeline

var-const created this revision.Jan 30 2023, 7:47 PM
Herald added a project: Restricted Project. · View Herald TranscriptJan 30 2023, 7:47 PM
var-const requested review of this revision.Jan 30 2023, 7:47 PM
Herald added a project: Restricted Project. · View Herald TranscriptJan 30 2023, 7:47 PM
Herald added a reviewer: Restricted Project. · View Herald Transcript
Herald added a subscriber: libcxx-commits. · View Herald Transcript
Harbormaster completed remote builds in B210902: Diff 493476.Jan 30 2023, 7:51 PM
philnik accepted this revision.Jan 31 2023, 1:13 AM
This revision is now accepted and ready to land.Jan 31 2023, 1:13 AM
ldionne accepted this revision.Jan 31 2023, 11:08 AM
ldionne added a subscriber: ldionne.
ldionne added inline comments.
libcxx/test/std/ranges/range.adaptors/range.elements/sentinel/minus.pass.cpp
27
35
var-const updated this revision to Diff 493750.Jan 31 2023, 3:28 PM

Feedback

var-const marked 2 inline comments as done.Jan 31 2023, 3:28 PM
This revision was landed with ongoing or failed builds.Jan 31 2023, 3:29 PM
Closed by commit rG3fe3f9c51cba: [libc++][ranges] Fix incorrect integer typedef in `elements_view` test. (authored by var-const, committed by varconst <varconsteq@gmail.com>). · Explain Why
This revision was automatically updated to reflect the committed changes.
varconst <varconsteq@gmail.com> added a commit: rG3fe3f9c51cba: [libc++][ranges] Fix incorrect integer typedef in `elements_view` test..
Harbormaster completed remote builds in B211086: Diff 493750.Jan 31 2023, 7:02 PM

Revision Contents

PathSize
libcxx/
test/
std/
ranges/
range.adaptors/
range.elements/
sentinel/
3 lines

Diff 493750

libcxx/test/std/ranges/range.adaptors/range.elements/sentinel/minus.pass.cpp

Show All 14 Lines
// //
// template<bool OtherConst> // template<bool OtherConst>
// requires sized_sentinel_for<sentinel_t<Base>, iterator_t<maybe-const<OtherConst, V>>> // requires sized_sentinel_for<sentinel_t<Base>, iterator_t<maybe-const<OtherConst, V>>>
// friend constexpr range_difference_t<maybe-const<OtherConst, V>> // friend constexpr range_difference_t<maybe-const<OtherConst, V>>
// operator-(const sentinel& x, const iterator<OtherConst>& y); // operator-(const sentinel& x, const iterator<OtherConst>& y);
#include <cassert> #include <cassert>
#include <concepts> #include <concepts>
#include <cstddef>
#include <functional> #include <functional>
#include <ranges> #include <ranges>
#include <tuple> #include <tuple>
ldionneUnsubmitted
Done
ReplyInline Actions
#include <tuple>
+ #include <cstddef>
#include "../types.h"
ldionne:
#include "../types.h" #include "../types.h"
template <bool Const> template <bool Const>
struct Iter { struct Iter {
std::tuple<int>* it_; std::tuple<int>* it_;
using value_type = std::tuple<int>; using value_type = std::tuple<int>;
using difference_type = intptr_t; using difference_type = std::ptrdiff_t;
ldionneUnsubmitted
Done
ReplyInline Actions
using value_type = std::tuple<int>;
- using difference_type = ptrdiff_t;
+ using difference_type = std::ptrdiff_t;
using iterator_concept = std::input_iterator_tag;
ldionne:
using iterator_concept = std::input_iterator_tag; using iterator_concept = std::input_iterator_tag;
constexpr decltype(auto) operator*() const { return *it_; } constexpr decltype(auto) operator*() const { return *it_; }
constexpr Iter& operator++() { constexpr Iter& operator++() {
++it_; ++it_;
return *this; return *this;
} }
constexpr void operator++(int) { ++it_; } constexpr void operator++(int) { ++it_; }
▲ Show 20 Lines • Show All 171 Lines • Show Last 20 Lines