This is an archive of the discontinued LLVM Phabricator instance.

[hexagon] add a -mcabac flag

Authored by bcain on Jan 30 2023, 6:31 PM.



For v73 and later, clang users who wish to use the cabac instructions need
a way to add the 'cabac' target feature.

Diff Detail

Event Timeline

bcain created this revision.Jan 30 2023, 6:31 PM
Herald added a project: Restricted Project. · View Herald TranscriptJan 30 2023, 6:31 PM
bcain requested review of this revision.Jan 30 2023, 6:31 PM
bcain added a subscriber: ldionne.Jan 31 2023, 9:00 AM

It seems extremely unlikely that this change to target-dependent flags caused this libc++ test failure w/an error referring to partial specialization.

@ldionne is it possible that special_mem_concepts::nothrow_sentinel_for.compile.pass.cpp is failing on the baseline?

In module 'std' imported from /home/libcxx-builder/.buildkite-agent/builds/7288bc8bb028-1/llvm-project/libcxx-ci/libcxx/test/libcxx/algorithms/specialized.algorithms/special.mem.concepts/nothrow_sentinel_for.compile.pass.cpp:14:
/home/libcxx-builder/.buildkite-agent/builds/7288bc8bb028-1/llvm-project/libcxx-ci/build/generic-modules/include/c++/v1/__concepts/same_as.h:29:34: error: partial specialization of 'common_reference<_Tp, _Up>' must be imported from module 'std.type_traits.common_reference' before it is required
concept same_as = __same_as_impl<_Tp, _Up> && __same_as_impl<_Up, _Tp>;
/home/libcxx-builder/.buildkite-agent/builds/7288bc8bb028-1/llvm-project/libcxx-ci/libcxx/test/libcxx/algorithms/specialized.algorithms/special.mem.concepts/nothrow_sentinel_for.compile.pass.cpp:23:80: note: while substituting into concept arguments here; substitution failures not allowed in concept arguments
constexpr bool ntsf_subsumes_sf(std::ranges::__nothrow_sentinel_for<char*> auto) requires true {
/home/libcxx-builder/.buildkite-agent/builds/7288bc8bb028-1/llvm-project/libcxx-ci/build/generic-modules/include/c++/v1/__type_traits/common_reference.h:133:40: note: partial specialization declared here is not reachable
template <class _Tp, class _Up> struct common_reference<_Tp, _Up> : __common_reference_sub_bullet1<_Tp, _Up> {};
1 error generated.
kparzysz accepted this revision.Jan 31 2023, 11:50 AM

The cxx tests passed for me.

This revision is now accepted and ready to land.Jan 31 2023, 11:50 AM
This revision was landed with ongoing or failed builds.Jan 31 2023, 4:30 PM
This revision was automatically updated to reflect the committed changes.