This is an archive of the discontinued LLVM Phabricator instance.

Differential D142706

[GVN] Add pre-commit tests for address translation through select (D142705)
ClosedPublic

Authored by kachkov98 on Jan 27 2023, 4:54 AM.

Details

Reviewers
mkazantsev
Commits
rGfdeafafe4900: [GVN] Add pre-commit tests for address translation through select (D142705)

Diff Detail

Event Timeline

kachkov98 created this revision.Jan 27 2023, 4:54 AM
Herald added a project: Restricted Project. · View Herald TranscriptJan 27 2023, 4:54 AM
kachkov98 requested review of this revision.Jan 27 2023, 4:54 AM
Herald added a project: Restricted Project. · View Herald TranscriptJan 27 2023, 4:54 AM
Herald added a subscriber: llvm-commits. · View Herald Transcript
kachkov98 added a child revision: D142705: [GVN] Support address translation through select instructions.Jan 27 2023, 5:12 AM
Harbormaster completed remote builds in B210321: Diff 492707.Jan 27 2023, 5:44 AM
mkazantsev accepted this revision.Jan 29 2023, 11:32 PM
mkazantsev added a subscriber: mkazantsev.

I think this can go w/o review.

This revision is now accepted and ready to land.Jan 29 2023, 11:32 PM
Herald added a subscriber: StephenFan. · View Herald TranscriptJan 29 2023, 11:32 PM
Closed by commit rGfdeafafe4900: [GVN] Add pre-commit tests for address translation through select (D142705) (authored by kachkov98). · Explain WhyFeb 1 2023, 5:27 AM
This revision was automatically updated to reflect the committed changes.
kachkov98 added a commit: rGfdeafafe4900: [GVN] Add pre-commit tests for address translation through select (D142705).

Revision Contents

PathSize
llvm/
test/
Transforms/
GVN/
PRE/
98 lines

Diff 492707

llvm/test/Transforms/GVN/PRE/pre-load-through-select.ll

Show First 20 Lines • Show All 824 Lines • ▼ Show 20 Linesentry:
%l.1 = load i32, ptr %a, align 4 %l.1 = load i32, ptr %a, align 4
%l.2 = load i32, ptr %b, align 4 %l.2 = load i32, ptr %b, align 4
%cmp.i.i.i = icmp ult i32 %l.1, %l.2 %cmp.i.i.i = icmp ult i32 %l.1, %l.2
%min.select = select i1 %cmp.i.i.i, ptr %a, ptr %b %min.select = select i1 %cmp.i.i.i, ptr %a, ptr %b
%res.0 = load i32, ptr %min.select, align 4 %res.0 = load i32, ptr %min.select, align 4
store i32 99, ptr %c store i32 99, ptr %c
ret i32 %res.0 ret i32 %res.0
} }
define i32 @test_phi_select_index_non_local(ptr %A, i32 %N, i32 %i) {
; CHECK-LABEL: @test_phi_select_index_non_local(
; CHECK-NEXT: entry:
; CHECK-NEXT: [[CMP:%.*]] = icmp slt i32 [[I:%.*]], [[N:%.*]]
; CHECK-NEXT: br i1 [[CMP]], label [[LAND_LHS_TRUE:%.*]], label [[IF_END:%.*]]
; CHECK: land.lhs.true:
; CHECK-NEXT: [[IDXPROM:%.*]] = sext i32 [[I]] to i64
; CHECK-NEXT: [[ARRAYIDX:%.*]] = getelementptr inbounds i32, ptr [[A:%.*]], i64 [[IDXPROM]]
; CHECK-NEXT: [[TMP0:%.*]] = load i32, ptr [[ARRAYIDX]], align 4
; CHECK-NEXT: [[ADD:%.*]] = add nsw i32 [[I]], 1
; CHECK-NEXT: [[IDXPROM1:%.*]] = sext i32 [[ADD]] to i64
; CHECK-NEXT: [[ARRAYIDX2:%.*]] = getelementptr inbounds i32, ptr [[A]], i64 [[IDXPROM1]]
; CHECK-NEXT: [[TMP1:%.*]] = load i32, ptr [[ARRAYIDX2]], align 4
; CHECK-NEXT: [[CMP3:%.*]] = icmp slt i32 [[TMP0]], [[TMP1]]
; CHECK-NEXT: [[SPEC_SELECT:%.*]] = select i1 [[CMP3]], i32 [[ADD]], i32 [[I]]
; CHECK-NEXT: br label [[IF_END]]
; CHECK: if.end:
; CHECK-NEXT: [[I_ADDR_0:%.*]] = phi i32 [ [[I]], [[ENTRY:%.*]] ], [ [[SPEC_SELECT]], [[LAND_LHS_TRUE]] ]
; CHECK-NEXT: [[IDXPROM5:%.*]] = sext i32 [[I_ADDR_0]] to i64
; CHECK-NEXT: [[ARRAYIDX6:%.*]] = getelementptr inbounds i32, ptr [[A]], i64 [[IDXPROM5]]
; CHECK-NEXT: [[TMP2:%.*]] = load i32, ptr [[ARRAYIDX6]], align 4
; CHECK-NEXT: ret i32 [[TMP2]]
;
entry:
%cmp = icmp slt i32 %i, %N
br i1 %cmp, label %land.lhs.true, label %if.end
land.lhs.true:
%idxprom = sext i32 %i to i64
%arrayidx = getelementptr inbounds i32, ptr %A, i64 %idxprom
%0 = load i32, ptr %arrayidx, align 4
%add = add nsw i32 %i, 1
%idxprom1 = sext i32 %add to i64
%arrayidx2 = getelementptr inbounds i32, ptr %A, i64 %idxprom1
%1 = load i32, ptr %arrayidx2, align 4
%cmp3 = icmp slt i32 %0, %1
%spec.select = select i1 %cmp3, i32 %add, i32 %i
br label %if.end
if.end:
%i.addr.0 = phi i32 [ %i, %entry ], [ %spec.select, %land.lhs.true ]
%idxprom5 = sext i32 %i.addr.0 to i64
%arrayidx6 = getelementptr inbounds i32, ptr %A, i64 %idxprom5
%2 = load i32, ptr %arrayidx6, align 4
ret i32 %2
}
define i32 @test_phi_select_index_loop(ptr %A, i32 %N) {
; CHECK-LABEL: @test_phi_select_index_loop(
; CHECK-NEXT: entry:
; CHECK-NEXT: [[CMP:%.*]] = icmp sgt i32 [[N:%.*]], 1
; CHECK-NEXT: br i1 [[CMP]], label [[FOR_BODY_PREHEADER:%.*]], label [[FOR_COND_CLEANUP:%.*]]
; CHECK: for.body.preheader:
; CHECK-NEXT: br label [[FOR_BODY:%.*]]
; CHECK: for.body:
; CHECK-NEXT: [[IDX:%.*]] = phi i32 [ [[IDX_NEXT:%.*]], [[FOR_BODY]] ], [ 1, [[FOR_BODY_PREHEADER]] ]
; CHECK-NEXT: [[RES:%.*]] = phi i32 [ [[SPEC_SELECT:%.*]], [[FOR_BODY]] ], [ 0, [[FOR_BODY_PREHEADER]] ]
; CHECK-NEXT: [[IDXPROM:%.*]] = sext i32 [[IDX]] to i64
; CHECK-NEXT: [[ARRAYIDX:%.*]] = getelementptr inbounds i32, ptr [[A:%.*]], i64 [[IDXPROM]]
; CHECK-NEXT: [[TMP0:%.*]] = load i32, ptr [[ARRAYIDX]], align 4
; CHECK-NEXT: [[IDXPROM1:%.*]] = sext i32 [[RES]] to i64
; CHECK-NEXT: [[ARRAYIDX1:%.*]] = getelementptr inbounds i32, ptr [[A]], i64 [[IDXPROM1]]
; CHECK-NEXT: [[TMP1:%.*]] = load i32, ptr [[ARRAYIDX1]], align 4
; CHECK-NEXT: [[CMP1:%.*]] = icmp slt i32 [[TMP0]], [[TMP1]]
; CHECK-NEXT: [[SPEC_SELECT]] = select i1 [[CMP1]], i32 [[IDX]], i32 [[RES]]
; CHECK-NEXT: [[IDX_NEXT]] = add nsw i32 [[IDX]], 1
; CHECK-NEXT: [[EXITCOND_NOT:%.*]] = icmp eq i32 [[IDX_NEXT]], [[N]]
; CHECK-NEXT: br i1 [[EXITCOND_NOT]], label [[FOR_COND_CLEANUP_LOOPEXIT:%.*]], label [[FOR_BODY]]
; CHECK: for.cond.cleanup.loopexit:
; CHECK-NEXT: br label [[FOR_COND_CLEANUP]]
; CHECK: for.cond.cleanup:
; CHECK-NEXT: [[RES_0_LCSSA:%.*]] = phi i32 [ 0, [[ENTRY:%.*]] ], [ [[SPEC_SELECT]], [[FOR_COND_CLEANUP_LOOPEXIT]] ]
; CHECK-NEXT: ret i32 [[RES_0_LCSSA]]
;
entry:
%cmp = icmp sgt i32 %N, 1
br i1 %cmp, label %for.body, label %for.cond.cleanup
for.body:
%idx = phi i32 [ 1, %entry ], [ %idx.next, %for.body ]
%res = phi i32 [ 0, %entry ], [ %spec.select, %for.body ]
%idxprom = sext i32 %idx to i64
%arrayidx = getelementptr inbounds i32, ptr %A, i64 %idxprom
%0 = load i32, ptr %arrayidx, align 4
%idxprom1 = sext i32 %res to i64
%arrayidx1 = getelementptr inbounds i32, ptr %A, i64 %idxprom1
%1 = load i32, ptr %arrayidx1, align 4
%cmp1 = icmp slt i32 %0, %1
%spec.select = select i1 %cmp1, i32 %idx, i32 %res
%idx.next = add nsw i32 %idx, 1
%exitcond.not = icmp eq i32 %idx.next, %N
br i1 %exitcond.not, label %for.cond.cleanup, label %for.body
for.cond.cleanup:
%res.0.lcssa = phi i32 [ 0, %entry ], [ %spec.select, %for.body ]
ret i32 %res.0.lcssa
}