A lot of tests are disabled by using UNSUPPORTED. The plan is to remove UNSUPPORTED for tests that are fixed.
Details
Diff Detail
- Repository
- rG LLVM Github Monorepo
Unit Tests
Event Timeline
compiler-rt/test/lsan/CMakeLists.txt | ||
---|---|---|
30 | why if (arch STREQUAL "x86_64")? |
compiler-rt/test/lsan/CMakeLists.txt | ||
---|---|---|
30 | Done. |
I think this broke Mac: https://green.lab.llvm.org/green/job/clang-stage1-RA/32739/
For example:
LeakSanitizer-HWAddressSanitizer-x86_64.TestCases/Darwin.dispatch.mm (from LeakSanitizer-HWAddressSanitizer-x86_64) + : 'RUN: at line 2' + /Users/buildslave/jenkins/workspace/clang-stage1-RA@2/clang-build/./bin/clang --driver-mode=g++ -O0 -arch x86_64 -stdlib=libc++ -mmacosx-version-min=10.10 -isysroot /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX11.1.sdk -gline-tables-only -fsanitize=hwaddress -fuse-ld=lld -fsanitize-hwaddress-experimental-aliasing -I/Users/buildslave/jenkins/workspace/clang-stage1-RA@2/llvm-project/compiler-rt/test/lsan/../ /Users/buildslave/jenkins/workspace/clang-stage1-RA@2/llvm-project/compiler-rt/test/lsan/TestCases/Darwin/dispatch.mm -DDISPATCH_ASYNC -o /Users/buildslave/jenkins/workspace/clang-stage1-RA@2/clang-build/tools/clang/runtime/compiler-rt-bins/test/lsan/X86_64HWAsanConfig/TestCases/Darwin/Output/dispatch.mm.tmp-async -framework Foundation clang-17: error: unsupported option '-fsanitize=hwaddress' for target 'x86_64-apple-darwin19.5.0' clang-17: error: invalid linker name in argument '-fuse-ld=lld'
Looks like -fsanitize=hwaddress is not supported on Mac. I re-landed this with Mac disabled. Will keep an eye on your builds.
I am working on generic support, focusing on x86 for now. Theoretically it should work on ARM, but I haven't tried that. I am also not sure is there anything specific which needs to be done to make it work on Android on top of making it work on ARM. You can try flipping the cf.detect_leaks flag in compiler-rt/lib/hwasan/hwasan.cpp to see if it works :-)
compiler-rt/test/lsan/CMakeLists.txt | ||
---|---|---|
32 | We should make hwasan unsupported on lib/ level |
why if (arch STREQUAL "x86_64")?
add FIXME if it's temporarily