Details
Details
- Reviewers
ldionne Mordante var-const - Group Reviewers
Restricted Project - Commits
- rG934650b24fbf: [libc++] Add [[clang::lifetimebound]] to min/max algorithms
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
Comment Actions
LGTM modulo one remark. Note the CI failure has already been fixed.
libcxx/include/module.modulemap.in | ||
---|---|---|
303 | Can you specify what exactly is exported. The * seems quite fragile when refactoring header includes. |
libcxx/include/module.modulemap.in | ||
---|---|---|
303 | I tried that and couldn't find out what exactly the problem is. I'd rather try to fix it in a separate patch, since it doesn't seem super important and might be quite a bit of work. |
libcxx/include/module.modulemap.in | ||
---|---|---|
303 | SGTM. |
Can you specify what exactly is exported. The * seems quite fragile when refactoring header includes.