This is an archive of the discontinued LLVM Phabricator instance.

[libc++] Add documentation for reproducing CI issues locally
ClosedPublic

Authored by ldionne on Jan 25 2023, 10:09 AM.

Details

Diff Detail

Event Timeline

ldionne created this revision.Jan 25 2023, 10:09 AM
Herald added a project: Restricted Project. · View Herald TranscriptJan 25 2023, 10:09 AM
ldionne requested review of this revision.Jan 25 2023, 10:09 AM
Herald added a project: Restricted Project. · View Herald TranscriptJan 25 2023, 10:09 AM
Herald added a reviewer: Restricted Project. · View Herald Transcript
Mordante accepted this revision as: Mordante.Jan 25 2023, 10:25 AM
Mordante added a subscriber: Mordante.

Thanks for working on this! LGTM modulo one request.

libcxx/docs/TestingLibcxx.rst
115

run-buildbot in our CI often sets CC and CXX. Can you add some documentation explaining that these environment variable might need to be exported before calling run-buildbot?

ldionne updated this revision to Diff 492540.Jan 26 2023, 11:52 AM
ldionne marked an inline comment as done.

Address comments.

This revision was not accepted when it landed; it landed in state Needs Review.Jan 26 2023, 11:52 AM
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
jloser added a subscriber: jloser.Jan 26 2023, 4:36 PM

Thanks for writing this up for others' benefit! I remember when you first showed me this a long time ago, I was really thankful for helping track down a CI failure.