This is an archive of the discontinued LLVM Phabricator instance.

[libc] fix strtointmax tests
ClosedPublic

Authored by michaelrj on Jan 24 2023, 4:11 PM.

Details

Summary

The strtointmax tests weren't running because they depend on the same
shared logic as strtol tests and the target for that was being defined
after the inttypes targets, causing them to be skipped. This patch moves
the inttypes test directory later in the order so that the shared tests
are defined before inttypes tests try to use them.

Diff Detail

Event Timeline

michaelrj created this revision.Jan 24 2023, 4:11 PM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptJan 24 2023, 4:11 PM
michaelrj requested review of this revision.Jan 24 2023, 4:11 PM
lntue accepted this revision.Jan 25 2023, 6:58 AM
This revision is now accepted and ready to land.Jan 25 2023, 6:58 AM
sivachandra accepted this revision.Jan 25 2023, 8:32 AM
sivachandra added inline comments.
libc/test/src/CMakeLists.txt
36

Why is order changed here?

michaelrj marked an inline comment as done.Jan 25 2023, 10:28 AM
michaelrj added inline comments.
libc/test/src/CMakeLists.txt
36

When inttypes is before stdlib, then the strtoimax and strtoumax tests are skipped because the strtol_test_support is not yet defined.

This revision was automatically updated to reflect the committed changes.
michaelrj marked an inline comment as done.