This is an archive of the discontinued LLVM Phabricator instance.

Differential D142511

[clang][test] Remove check that fails if SOURCE_DATE_EPOCH is set globally
ClosedPublic

Authored by benlangmuir on Jan 24 2023, 3:37 PM.

Details

Reviewers
tstellar
MaskRay
Commits
rG0245dcc000fa: [clang][test] Remove check that fails if SOURCE_DATE_EPOCH is set globally
Summary

The check for "no SOURCE_DATE_EPOCH" wasn't especially interesting, and I am not aware of a _portable_ way to unset and environment variable in a lit test. So remove it since it can fail if the build environment has SOURCE_DATE_EPOCH set globally.

Diff Detail

Event Timeline

benlangmuir created this revision.Jan 24 2023, 3:37 PM
Herald added a project: Restricted Project. · View Herald TranscriptJan 24 2023, 3:37 PM
benlangmuir requested review of this revision.Jan 24 2023, 3:38 PM
Herald added a project: Restricted Project. · View Herald TranscriptJan 24 2023, 3:38 PM
Herald added a subscriber: cfe-commits. · View Herald Transcript
benlangmuir mentioned this in D136717: [clang] Move getenv call for SOURCE_DATE_EPOCH out of frontend NFC.Jan 24 2023, 3:38 PM
tstellar accepted this revision.Jan 24 2023, 3:40 PM

LGTM. Thank you.

This revision is now accepted and ready to land.Jan 24 2023, 3:40 PM
MaskRay accepted this revision.Jan 24 2023, 3:52 PM
This revision was landed with ongoing or failed builds.Jan 24 2023, 4:01 PM
Closed by commit rG0245dcc000fa: [clang][test] Remove check that fails if SOURCE_DATE_EPOCH is set globally (authored by benlangmuir). · Explain Why
This revision was automatically updated to reflect the committed changes.
benlangmuir added a commit: rG0245dcc000fa: [clang][test] Remove check that fails if SOURCE_DATE_EPOCH is set globally.
Harbormaster completed remote builds in B209767: Diff 491938.Jan 24 2023, 7:01 PM

Revision Contents

PathSize
clang/
test/
Driver/
3 lines

Diff 491948

clang/test/Driver/SOURCE_DATE_EPOCH.c

// RUN: %clang -E %s -### 2>&1 | FileCheck %s -check-prefix=NO_EPOCH
// NO_EPOCH-NOT: "-source-date-epoch"
// RUN: env SOURCE_DATE_EPOCH=123 %clang -E %s -### 2>&1 | FileCheck %s // RUN: env SOURCE_DATE_EPOCH=123 %clang -E %s -### 2>&1 | FileCheck %s
// CHECK: "-source-date-epoch" "123" // CHECK: "-source-date-epoch" "123"