This is an archive of the discontinued LLVM Phabricator instance.

Differential D142252

[InstCombine] Add tests for ctpop(Pow2); NFC
ClosedPublic

Authored by goldstein.w.n on Jan 20 2023, 1:38 PM.

Details

Reviewers
nikic
spatel
majnemer
Commits
rG6082420945c8: Add tests for ctpop(Pow2); NFC

Diff Detail

Event Timeline

goldstein.w.n created this revision.Jan 20 2023, 1:38 PM
Herald added a project: Restricted Project. · View Herald TranscriptJan 20 2023, 1:38 PM
goldstein.w.n requested review of this revision.Jan 20 2023, 1:38 PM
Herald added a project: Restricted Project. · View Herald TranscriptJan 20 2023, 1:38 PM
Herald added a subscriber: llvm-commits. · View Herald Transcript
goldstein.w.n added a child revision: D142253: [InstCombine] Transform ctpop(Pow2) -> icmp ne Pow2, 0.Jan 20 2023, 1:38 PM
goldstein.w.n added reviewers: nikic, spatel, majnemer.
Herald added a subscriber: StephenFan. · View Herald TranscriptJan 20 2023, 1:39 PM
Harbormaster completed remote builds in B209065: Diff 490964.Jan 20 2023, 4:00 PM
goldstein.w.n updated this revision to Diff 491029.Jan 20 2023, 9:13 PM

Just for sync

Harbormaster completed remote builds in B209112: Diff 491029.Jan 20 2023, 11:22 PM
nikic accepted this revision.Jan 21 2023, 1:12 AM

LGTM

This revision is now accepted and ready to land.Jan 21 2023, 1:12 AM
Closed by commit rG6082420945c8: Add tests for ctpop(Pow2); NFC (authored by goldstein.w.n). · Explain WhyJan 21 2023, 11:08 PM
This revision was automatically updated to reflect the committed changes.
goldstein.w.n added a commit: rG6082420945c8: Add tests for ctpop(Pow2); NFC.

Revision Contents

PathSize
llvm/
test/
Transforms/
InstCombine/
162 lines

Diff 491133

llvm/test/Transforms/InstCombine/ctpop-pow2.ll

  • This file was added.
; NOTE: Assertions have been autogenerated by utils/update_test_checks.py
; RUN: opt < %s -passes=instcombine -S | FileCheck %s
declare i64 @llvm.ctpop.i64(i64)
declare i32 @llvm.ctpop.i32(i32)
declare i16 @llvm.ctpop.i16(i16)
declare i8 @llvm.ctpop.i8(i8)
declare <2 x i32> @llvm.ctpop.v2i32(<2 x i32>)
declare <2 x i64> @llvm.ctpop.v2i64(<2 x i64>)
declare void @llvm.assume(i1)
define i16 @ctpop_x_and_negx(i16 %x) {
; CHECK-LABEL: @ctpop_x_and_negx(
; CHECK-NEXT: [[V0:%.*]] = sub i16 0, [[X:%.*]]
; CHECK-NEXT: [[V1:%.*]] = and i16 [[V0]], [[X]]
; CHECK-NEXT: [[CNT:%.*]] = call i16 @llvm.ctpop.i16(i16 [[V1]]), !range [[RNG0:![0-9]+]]
; CHECK-NEXT: ret i16 [[CNT]]
;
%v0 = sub i16 0, %x
%v1 = and i16 %x, %v0
%cnt = call i16 @llvm.ctpop.i16(i16 %v1)
ret i16 %cnt
}
define i8 @ctpop_x_nz_and_negx(i8 %x) {
; CHECK-LABEL: @ctpop_x_nz_and_negx(
; CHECK-NEXT: [[X1:%.*]] = or i8 [[X:%.*]], 1
; CHECK-NEXT: [[V0:%.*]] = sub nsw i8 0, [[X1]]
; CHECK-NEXT: [[V1:%.*]] = and i8 [[X1]], [[V0]]
; CHECK-NEXT: [[CNT:%.*]] = call i8 @llvm.ctpop.i8(i8 [[V1]]), !range [[RNG1:![0-9]+]]
; CHECK-NEXT: ret i8 [[CNT]]
;
%x1 = or i8 %x, 1
%v0 = sub i8 0, %x1
%v1 = and i8 %x1, %v0
%cnt = call i8 @llvm.ctpop.i8(i8 %v1)
ret i8 %cnt
}
define i32 @ctpop_2_shl(i32 %x) {
; CHECK-LABEL: @ctpop_2_shl(
; CHECK-NEXT: [[V:%.*]] = shl i32 2, [[X:%.*]]
; CHECK-NEXT: [[CNT:%.*]] = call i32 @llvm.ctpop.i32(i32 [[V]]), !range [[RNG2:![0-9]+]]
; CHECK-NEXT: ret i32 [[CNT]]
;
%v = shl i32 2, %x
%cnt = call i32 @llvm.ctpop.i32(i32 %v)
ret i32 %cnt
}
define i32 @ctpop_2_shl_nz(i32 %x) {
; CHECK-LABEL: @ctpop_2_shl_nz(
; CHECK-NEXT: [[XA30:%.*]] = and i32 [[X:%.*]], 30
; CHECK-NEXT: [[V:%.*]] = shl i32 2, [[XA30]]
; CHECK-NEXT: [[CNT:%.*]] = call i32 @llvm.ctpop.i32(i32 [[V]]), !range [[RNG3:![0-9]+]]
; CHECK-NEXT: ret i32 [[CNT]]
;
%xa30 = and i32 30, %x
%v = shl i32 2, %xa30
%cnt = call i32 @llvm.ctpop.i32(i32 %v)
ret i32 %cnt
}
define i8 @ctpop_imin_plus1_lshr_nz(i8 %x) {
; CHECK-LABEL: @ctpop_imin_plus1_lshr_nz(
; CHECK-NEXT: [[CMP:%.*]] = icmp ne i8 [[X:%.*]], 0
; CHECK-NEXT: call void @llvm.assume(i1 [[CMP]])
; CHECK-NEXT: [[V:%.*]] = lshr i8 -127, [[X]]
; CHECK-NEXT: [[CNT:%.*]] = call i8 @llvm.ctpop.i8(i8 [[V]]), !range [[RNG4:![0-9]+]]
; CHECK-NEXT: ret i8 [[CNT]]
;
%cmp = icmp ne i8 %x, 0
call void @llvm.assume(i1 %cmp)
%v = lshr i8 129, %x
%cnt = call i8 @llvm.ctpop.i8(i8 %v)
ret i8 %cnt
}
define i64 @ctpop_x_and_negx_nz(i64 %x) {
; CHECK-LABEL: @ctpop_x_and_negx_nz(
; CHECK-NEXT: [[V0:%.*]] = sub i64 0, [[X:%.*]]
; CHECK-NEXT: [[V1:%.*]] = and i64 [[V0]], [[X]]
; CHECK-NEXT: [[CMP:%.*]] = icmp ne i64 [[V1]], 0
; CHECK-NEXT: call void @llvm.assume(i1 [[CMP]])
; CHECK-NEXT: [[CNT:%.*]] = call i64 @llvm.ctpop.i64(i64 [[V1]]), !range [[RNG5:![0-9]+]]
; CHECK-NEXT: ret i64 [[CNT]]
;
%v0 = sub i64 0, %x
%v1 = and i64 %x, %v0
%cmp = icmp ne i64 %v1, 0
call void @llvm.assume(i1 %cmp)
%cnt = call i64 @llvm.ctpop.i64(i64 %v1)
ret i64 %cnt
}
define <2 x i32> @ctpop_shl2_1_vec(<2 x i32> %x) {
; CHECK-LABEL: @ctpop_shl2_1_vec(
; CHECK-NEXT: [[SHL:%.*]] = shl <2 x i32> <i32 2, i32 1>, [[X:%.*]]
; CHECK-NEXT: [[CNT:%.*]] = call <2 x i32> @llvm.ctpop.v2i32(<2 x i32> [[SHL]])
; CHECK-NEXT: ret <2 x i32> [[CNT]]
;
%shl = shl <2 x i32> <i32 2 ,i32 1>, %x
%cnt = call <2 x i32> @llvm.ctpop.v2i32(<2 x i32> %shl)
ret <2 x i32> %cnt
}
define <2 x i32> @ctpop_lshr_intmin_intmin_plus1_vec_nz(<2 x i32> %x) {
; CHECK-LABEL: @ctpop_lshr_intmin_intmin_plus1_vec_nz(
; CHECK-NEXT: [[X1:%.*]] = or <2 x i32> [[X:%.*]], <i32 1, i32 1>
; CHECK-NEXT: [[SHR:%.*]] = lshr <2 x i32> <i32 -2147483648, i32 -2147483647>, [[X1]]
; CHECK-NEXT: [[CNT:%.*]] = call <2 x i32> @llvm.ctpop.v2i32(<2 x i32> [[SHR]])
; CHECK-NEXT: ret <2 x i32> [[CNT]]
;
%x1 = or <2 x i32> %x, <i32 1 ,i32 1>
%shr = lshr <2 x i32> <i32 2147483648 ,i32 2147483649>, %x1
%cnt = call <2 x i32> @llvm.ctpop.v2i32(<2 x i32> %shr)
ret <2 x i32> %cnt
}
define <2 x i32> @ctpop_shl2_1_vec_nz(<2 x i32> %x) {
; CHECK-LABEL: @ctpop_shl2_1_vec_nz(
; CHECK-NEXT: [[AND:%.*]] = and <2 x i32> [[X:%.*]], <i32 15, i32 15>
; CHECK-NEXT: [[SHL:%.*]] = shl <2 x i32> <i32 2, i32 1>, [[AND]]
; CHECK-NEXT: [[CNT:%.*]] = call <2 x i32> @llvm.ctpop.v2i32(<2 x i32> [[SHL]])
; CHECK-NEXT: ret <2 x i32> [[CNT]]
;
%and = and <2 x i32> %x, <i32 15 ,i32 15>
%shl = shl <2 x i32> <i32 2 ,i32 1>, %and
%cnt = call <2 x i32> @llvm.ctpop.v2i32(<2 x i32> %shl)
ret <2 x i32> %cnt
}
define <2 x i64> @ctpop_x_and_negx_vec(<2 x i64> %x) {
; CHECK-LABEL: @ctpop_x_and_negx_vec(
; CHECK-NEXT: [[SUB:%.*]] = sub <2 x i64> zeroinitializer, [[X:%.*]]
; CHECK-NEXT: [[AND:%.*]] = and <2 x i64> [[SUB]], [[X]]
; CHECK-NEXT: [[CNT:%.*]] = call <2 x i64> @llvm.ctpop.v2i64(<2 x i64> [[AND]])
; CHECK-NEXT: ret <2 x i64> [[CNT]]
;
%sub = sub <2 x i64> <i64 0 ,i64 0>, %x
%and = and <2 x i64> %sub, %x
%cnt = call <2 x i64> @llvm.ctpop.v2i64(<2 x i64> %and)
ret <2 x i64> %cnt
}
define <2 x i32> @ctpop_x_and_negx_vec_nz(<2 x i32> %x) {
; CHECK-LABEL: @ctpop_x_and_negx_vec_nz(
; CHECK-NEXT: [[X1:%.*]] = or <2 x i32> [[X:%.*]], <i32 1, i32 1>
; CHECK-NEXT: [[SUB:%.*]] = sub nsw <2 x i32> zeroinitializer, [[X1]]
; CHECK-NEXT: [[AND:%.*]] = and <2 x i32> [[X1]], [[SUB]]
; CHECK-NEXT: [[CNT:%.*]] = call <2 x i32> @llvm.ctpop.v2i32(<2 x i32> [[AND]])
; CHECK-NEXT: ret <2 x i32> [[CNT]]
;
%x1 = or <2 x i32> %x, <i32 1 ,i32 1>
%sub = sub <2 x i32> <i32 0 ,i32 0>, %x1
%and = and <2 x i32> %sub, %x1
%cnt = call <2 x i32> @llvm.ctpop.v2i32(<2 x i32> %and)
ret <2 x i32> %cnt
}