This is an archive of the discontinued LLVM Phabricator instance.

Differential D142238

[clang/CodeGenActionTest] Use the platform's path separator for the `DebugInfoCWDCodeGen` test
ClosedPublic

Authored by akyrtzi on Jan 20 2023, 10:16 AM.

Details

Reviewers
None
Commits
rGb2b078adc2d0: [clang/CodeGenActionTest] Use the platform's path separator for the…
Summary

Fixes a failure in some Windows configuration.

Diff Detail

Unit TestsFailed

TimeTest
3,670 mslibcxx CI Modules > llvm-libc++-shared-cfg-in.libcxx/algorithms/specialized_algorithms/special_mem_concepts::nothrow_sentinel_for.compile.pass.cpp

Event Timeline

akyrtzi created this revision.Jan 20 2023, 10:16 AM
Herald added a project: Restricted Project. · View Herald TranscriptJan 20 2023, 10:16 AM
akyrtzi requested review of this revision.Jan 20 2023, 10:16 AM
Herald added a project: Restricted Project. · View Herald TranscriptJan 20 2023, 10:16 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript
Harbormaster completed remote builds in B209029: Diff 490907.Jan 20 2023, 12:46 PM
Herald added a subscriber: ormris. · View Herald TranscriptJan 20 2023, 12:46 PM
This revision was not accepted when it landed; it landed in state Needs Review.Jan 20 2023, 1:20 PM
This revision was landed with ongoing or failed builds.
Closed by commit rGb2b078adc2d0: [clang/CodeGenActionTest] Use the platform's path separator for the… (authored by akyrtzi). · Explain Why
This revision was automatically updated to reflect the committed changes.
akyrtzi added a commit: rGb2b078adc2d0: [clang/CodeGenActionTest] Use the platform's path separator for the….

Revision Contents

PathSize
clang/
unittests/
Frontend/
5 lines

Diff 490907

clang/unittests/Frontend/CodeGenActionTest.cpp

Show First 20 Lines • Show All 76 Lines • ▼ Show 20 LinesTEST(CodeGenTest, CodeGenFromIRMemBuffer) {
bool Success = Compiler.ExecuteAction(Action); bool Success = Compiler.ExecuteAction(Action);
EXPECT_TRUE(Success); EXPECT_TRUE(Success);
} }
TEST(CodeGenTest, DebugInfoCWDCodeGen) { TEST(CodeGenTest, DebugInfoCWDCodeGen) {
// Check that debug info is accessing the current working directory from the // Check that debug info is accessing the current working directory from the
// VFS instead of calling \p llvm::sys::fs::current_path() directly. // VFS instead of calling \p llvm::sys::fs::current_path() directly.
auto VFS = std::make_unique<llvm::vfs::InMemoryFileSystem>();
VFS->setCurrentWorkingDirectory("/in-memory-fs-cwd");
auto Sept = llvm::sys::path::get_separator(); auto Sept = llvm::sys::path::get_separator();
auto VFS = std::make_unique<llvm::vfs::InMemoryFileSystem>();
VFS->setCurrentWorkingDirectory(
std::string(llvm::formatv("{0}in-memory-fs-cwd", Sept)));
std::string TestPath = std::string TestPath =
std::string(llvm::formatv("{0}in-memory-fs-cwd{0}test.cpp", Sept)); std::string(llvm::formatv("{0}in-memory-fs-cwd{0}test.cpp", Sept));
VFS->addFile(TestPath, 0, llvm::MemoryBuffer::getMemBuffer("int x;\n")); VFS->addFile(TestPath, 0, llvm::MemoryBuffer::getMemBuffer("int x;\n"));
auto Invocation = std::make_shared<CompilerInvocation>(); auto Invocation = std::make_shared<CompilerInvocation>();
Invocation->getFrontendOpts().Inputs.push_back( Invocation->getFrontendOpts().Inputs.push_back(
FrontendInputFile("test.cpp", Language::CXX)); FrontendInputFile("test.cpp", Language::CXX));
Invocation->getFrontendOpts().ProgramAction = EmitLLVM; Invocation->getFrontendOpts().ProgramAction = EmitLLVM;
Show All 21 Lines