This is an archive of the discontinued LLVM Phabricator instance.

[clang] Use FP options from AST for emitting code for casts
ClosedPublic

Authored by sepavloff on Jan 18 2023, 2:44 AM.

Diff Detail

Event Timeline

sepavloff created this revision.Jan 18 2023, 2:44 AM
Herald added a project: Restricted Project. · View Herald TranscriptJan 18 2023, 2:44 AM
Herald added a subscriber: pengfei. · View Herald Transcript
sepavloff requested review of this revision.Jan 18 2023, 2:44 AM
Herald added a project: Restricted Project. · View Herald TranscriptJan 18 2023, 2:44 AM

Overall looks reasonable. One question about testing.

clang/test/CodeGen/X86/avx512dq-builtins-constrained.c
8–9

Can you use FileCheck --implicit-check-not to verify this?

sepavloff updated this revision to Diff 490504.Jan 19 2023, 7:06 AM

Use --implicit-check-not in tests

rjmccall accepted this revision.Jan 19 2023, 12:57 PM

LGTM, thanks.

This revision is now accepted and ready to land.Jan 19 2023, 12:57 PM
This revision was landed with ongoing or failed builds.Jan 20 2023, 5:48 AM
This revision was automatically updated to reflect the committed changes.