[InstCombine] Add tests for reoredering (shift (add (shift x, C0), y), C1); NFC
ClosedPublic
Actions

Authored by goldstein.w.n on Jan 16 2023, 3:21 PM.

Details

Reviewers

nikic
majnemer
spatel

Commits

rG8c884655862e: Add tests for reoredering (shift (add (shift x, C0), y), C1); NFC

Diff Detail

Repository: rG LLVM Github Monorepo

Event Timeline

goldstein.w.n created this revision.Jan 16 2023, 3:21 PM

Herald added a project: Restricted Project. · View Herald TranscriptJan 16 2023, 3:21 PM

goldstein.w.n requested review of this revision.Jan 16 2023, 3:21 PM

Herald added a project: Restricted Project. · View Herald TranscriptJan 16 2023, 3:21 PM

Herald added a subscriber: llvm-commits. · View Herald Transcript

goldstein.w.n retitled this revision from Add tests for reoredering (shift (add (shift x, C0), y), C1); NFC to [InstCombine] Add tests for reoredering (shift (add (shift x, C0), y), C1); NFC.Jan 16 2023, 3:22 PM

goldstein.w.n added reviewers: nikic, majnemer.

Herald added a subscriber: StephenFan. · View Herald TranscriptJan 16 2023, 3:22 PM

goldstein.w.n added a child revision: D141875: [InstCombine] Reorder (shl (add/sub (shl x, C0), y), C1) -> (add/sub (shl x, C0 + C1), (shl y, C1)).Jan 16 2023, 3:22 PM

Harbormaster completed remote builds in B208114: Diff 489641.Jan 16 2023, 4:52 PM

nikic added a reviewer: spatel.Jan 17 2023, 5:31 AM

Add tests for sub as well

Harbormaster completed remote builds in B208286: Diff 489875.Jan 17 2023, 11:32 AM

LGTM

llvm/test/Transforms/InstCombine/shift-logic.ll
379	It would be good to add a "negative test" comment to this set of tests (and the corresponding sub variants) in D141875. That way, it's clear that if they get changed somehow in a subsequent patch, it's probably a miscompile.