This is an archive of the discontinued LLVM Phabricator instance.

Differential D141833

[libcxx] Add missing includes
ClosedPublic

Authored by Michael137 on Jan 16 2023, 2:26 AM.

Details

Reviewers
ldionne
aprantl
philnik
Group Reviewers
Restricted Project
Commits
rG48e862d06d2f: [libcxx] Add missing includes
Summary

This fixes the remaining errors when building the llvm-project
with LLVM_ENABLE_MODULES=ON (and LLVM_ENABLE_LOCAL_SUBMODULE_VISIBILITY=ON,
which currently is the LLVM default).

Previously this would fail in the CXX_SUPPORTS_MODULES check.

Diff Detail

Event Timeline

Michael137 created this revision.Jan 16 2023, 2:26 AM
Herald added a project: Restricted Project. · View Herald TranscriptJan 16 2023, 2:26 AM
Michael137 requested review of this revision.Jan 16 2023, 2:26 AM
Herald added a project: Restricted Project. · View Herald TranscriptJan 16 2023, 2:26 AM
Herald added a reviewer: Restricted Project. · View Herald Transcript
Herald added a subscriber: libcxx-commits. · View Herald Transcript
Harbormaster completed remote builds in B207997: Diff 489473.Jan 16 2023, 2:57 AM
Michael137 updated this revision to Diff 489482.Jan 16 2023, 3:07 AM
  • Fix header llvm-include-order clang-tidy warning
Harbormaster completed remote builds in B208004: Diff 489482.Jan 16 2023, 4:29 AM
philnik accepted this revision.Jan 16 2023, 9:19 AM
philnik added a subscriber: philnik.

It sucks that we can't really test this without enabling modules by default, but I don't think modules are ready for that. LGTM.

This revision is now accepted and ready to land.Jan 16 2023, 9:19 AM
Closed by commit rG48e862d06d2f: [libcxx] Add missing includes (authored by Michael137). · Explain WhyJan 16 2023, 9:27 AM
This revision was automatically updated to reflect the committed changes.
Michael137 added a commit: rG48e862d06d2f: [libcxx] Add missing includes.
Michael137 mentioned this in rZORGf817ad740c61: [monorepo_build] Re-enable LLVM_ENABLE_MODULES for the LLDB incremental builds.Jan 16 2023, 9:34 AM
DoyleLi mentioned this in D158142: Improved InformativeMailNotifier..Aug 16 2023, 10:20 PM

Revision Contents

PathSize
libcxx/
include/
__iterator/
1 line
2 lines

Diff 489586

libcxx/include/__iterator/bounded_iter.h

Show All 9 Lines
#ifndef _LIBCPP___ITERATOR_BOUNDED_ITER_H #ifndef _LIBCPP___ITERATOR_BOUNDED_ITER_H
#define _LIBCPP___ITERATOR_BOUNDED_ITER_H #define _LIBCPP___ITERATOR_BOUNDED_ITER_H
#include <__assert> #include <__assert>
#include <__config> #include <__config>
#include <__iterator/iterator_traits.h> #include <__iterator/iterator_traits.h>
#include <__memory/pointer_traits.h> #include <__memory/pointer_traits.h>
#include <__type_traits/enable_if.h> #include <__type_traits/enable_if.h>
#include <__type_traits/integral_constant.h>
#include <__type_traits/is_convertible.h> #include <__type_traits/is_convertible.h>
#include <__utility/move.h> #include <__utility/move.h>
#if !defined(_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER) #if !defined(_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER)
# pragma GCC system_header # pragma GCC system_header
#endif #endif
_LIBCPP_BEGIN_NAMESPACE_STD _LIBCPP_BEGIN_NAMESPACE_STD
▲ Show 20 Lines • Show All 205 Lines • Show Last 20 Lines

libcxx/include/__iterator/move_iterator.h

Show All 22 Lines
#include <__iterator/iter_swap.h> #include <__iterator/iter_swap.h>
#include <__iterator/iterator_traits.h> #include <__iterator/iterator_traits.h>
#include <__iterator/move_sentinel.h> #include <__iterator/move_sentinel.h>
#include <__iterator/readable_traits.h> #include <__iterator/readable_traits.h>
#include <__type_traits/conditional.h> #include <__type_traits/conditional.h>
#include <__type_traits/enable_if.h> #include <__type_traits/enable_if.h>
#include <__type_traits/is_assignable.h> #include <__type_traits/is_assignable.h>
#include <__type_traits/is_constructible.h> #include <__type_traits/is_constructible.h>
#include <__type_traits/is_convertible.h>
#include <__type_traits/is_reference.h> #include <__type_traits/is_reference.h>
#include <__type_traits/is_same.h> #include <__type_traits/is_same.h>
#include <__type_traits/remove_reference.h>
#include <__utility/declval.h> #include <__utility/declval.h>
#include <__utility/move.h> #include <__utility/move.h>
#if !defined(_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER) #if !defined(_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER)
# pragma GCC system_header # pragma GCC system_header
#endif #endif
_LIBCPP_BEGIN_NAMESPACE_STD _LIBCPP_BEGIN_NAMESPACE_STD
▲ Show 20 Lines • Show All 293 Lines • Show Last 20 Lines