[Module] Respect `-fno-pch-timestamps` when building modules
ClosedPublic
Actions

Authored by steven_wu on Jan 12 2023, 1:47 PM.

Details

Reviewers

benlangmuir
akyrtzi
jansvoboda11

Commits

rG5cff68fca0bc: [Module] Respect `-fno-pch-timestamps` when building modules

Summary

Always respect the FrontendOption to not include timestamps in PCH or
Modules when -fno-pch-timestamps is specified.

Diff Detail

Repository: rG LLVM Github Monorepo

Event Timeline

steven_wu created this revision.Jan 12 2023, 1:47 PM

Herald added a project: Restricted Project. · View Herald TranscriptJan 12 2023, 1:47 PM

Herald added a subscriber: ributzka. · View Herald Transcript

steven_wu requested review of this revision.Jan 12 2023, 1:47 PM

Herald added a project: Restricted Project. · View Herald TranscriptJan 12 2023, 1:47 PM

Harbormaster completed remote builds in B207476: Diff 488764.Jan 12 2023, 2:50 PM

benlangmuir accepted this revision.Jan 20 2023, 10:56 AM

This revision is now accepted and ready to land.Jan 20 2023, 10:56 AM

This revision was landed with ongoing or failed builds.Feb 1 2023, 10:34 AM

Closed by commit rG5cff68fca0bc: [Module] Respect `-fno-pch-timestamps` when building modules (authored by steven_wu). · Explain Why

This revision was automatically updated to reflect the committed changes.

steven_wu added a commit: rG5cff68fca0bc: [Module] Respect `-fno-pch-timestamps` when building modules.

Revision Contents
Changeset List

Path

Size

clang/

lib/

Frontend/

FrontendActions.cpp

3 lines

test/

Modules/

timestamps.c

30 lines

Diff 494006

View Options

clang/lib/Frontend/FrontendActions.cpp