There is already support for Max counterparts. No reason why Min should
not be supported.
NFC: code in GetMinTrailingZeroes is copied for a couple node types.
Refactor them into a single code block.
Paths
| Differential D141568
[SCEV] Support SMin/Umin for GetMinTrailingZeros ClosedPublic Authored by caojoshua on Jan 11 2023, 11:25 PM.
Details Summary There is already support for Max counterparts. No reason why Min should NFC: code in GetMinTrailingZeroes is copied for a couple node types.
Diff Detail
Event TimelineThis comment was removed by caojoshua.
Comment Actions
I am unable to create a testcase for GetMinTrailingZeroes on UMinSequential All existing integration tests pass. Not sure if we need more testing, or we
This revision is now accepted and ready to land.Jan 13 2023, 12:58 AM This revision was landed with ongoing or failed builds.Jan 13 2023, 2:32 AM Closed by commit rG2f9f11180fde: [SCEV] Support all Min/Max SCEVs for GetMinTrailingZeros (authored by caojoshua). · Explain Why This revision was automatically updated to reflect the committed changes.
Revision Contents
Diff 488491 llvm/lib/Analysis/ScalarEvolution.cpp
llvm/test/Analysis/ScalarEvolution/trip-count-minmax.ll
|
While here, would you mind supporting UMinSeq as well?