This is an archive of the discontinued LLVM Phabricator instance.

[libunwind] Fixed an upcoming clang -Wsign-conversion warning
ClosedPublic

Authored by fahadnayyar on Jan 11 2023, 9:05 AM.

Details

Summary

Fixing an upcoming clang warning (from https://reviews.llvm.org/D139114) in libunwind.

Diff Detail

Event Timeline

fahadnayyar created this revision.Jan 11 2023, 9:05 AM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptJan 11 2023, 9:05 AM
Herald added a reviewer: Restricted Project. · View Herald Transcript
fahadnayyar requested review of this revision.Jan 11 2023, 9:05 AM
Herald added a project: Restricted Project. · View Herald TranscriptJan 11 2023, 9:05 AM
MaskRay accepted this revision.Jan 11 2023, 10:30 AM
MaskRay added a subscriber: MaskRay.

Thanks!

This revision is now accepted and ready to land.Jan 11 2023, 10:30 AM
housel added a subscriber: housel.Jan 11 2023, 1:15 PM
housel added inline comments.
libunwind/src/AddressSpace.hpp
263
MaskRay added inline comments.Jan 11 2023, 1:25 PM
libunwind/src/AddressSpace.hpp
263

return (int64_t)result; (delete space)

Removed space.

fahadnayyar marked an inline comment as done.

Correction.

fahadnayyar marked an inline comment as done.Jan 12 2023, 5:28 AM
MaskRay accepted this revision.Jan 12 2023, 10:25 AM

LGTM.

This revision was landed with ongoing or failed builds.Jan 13 2023, 8:02 AM
This revision was automatically updated to reflect the committed changes.