[libc++] Use _LIBCPP_HIDE_FROM_ABI_VIRTUAL instead of _LIBCPP_INLINE_VISIBILITY attribute on virtual function

[yronglin]

This patch try to fix CI failure https://buildkite.com/llvm-project/libcxx-ci/builds/17029#_

[ldionne]

Thanks for the catch. I'm not sure why I am not able to reproduce this failure locally.

libcxx/include/sstream

263

This should be _LIBCPP_HIDE_FROM_ABI_VIRTUAL.

[yronglin]

Use _LIBCPP_HIDE_FROM_ABI_VIRTUAL instead of _LIBCPP_INLINE_VISIBILITY attribute on virtual function

[yronglin]

libcxx/include/sstream

263

Thanks for your comments @ldionne I've updated this patch

[yronglin]

Seems another failure in clang_query.sh.cpp, but not the same problem as current. https://reviews.llvm.org/harbormaster/unit/view/5710580/

[ldionne]

LGTM once CI is green.

[yronglin]

In D141388#4040127, @ldionne wrote:

LGTM once CI is green.

Thanks for your review!

[ldionne]

LGTM, the CI failure is a flake.

[philnik]

LGTM. The CI failure is a fluke, you can just land this.

libcxx/include/sstream

 
 protected:
     // [stringbuf.virtuals] Overridden virtual functions:
     int_type underflow() override;
     int_type pbackfail(int_type __c = traits_type::eof()) override;
     int_type overflow (int_type __c = traits_type::eof()) override;
     pos_type seekoff(off_type __off, ios_base::seekdir __way,
                      ios_base::openmode __wch = ios_base::in | ios_base::out) override;
-    _LIBCPP_INLINE_VISIBILITY
+    _LIBCPP_HIDE_FROM_ABI_VIRTUAL
     pos_type seekpos(pos_type __sp,
                      ios_base::openmode __wch = ios_base::in | ios_base::out) override {
         return seekoff(__sp, ios_base::beg, __wch);
     }
 };
 
 template <class _CharT, class _Traits, class _Allocator>
 basic_stringbuf<_CharT, _Traits, _Allocator>::basic_stringbuf(basic_stringbuf&& __rhs)