Support for these CMake variables has been a warning for a while now. The
comment indicates to just remove the warning message entirely as anyone impacted
had to have update to new mechanisms in order to use libc++. So, remove the
warning message.
Details
Details
- Reviewers
ldionne philnik - Group Reviewers
Restricted Project - Commits
- rG07a341c2e4d9: [libc++] Remove warning for `LIBCXX_SYSROOT`, `LIBCXX_TARGET_TRIPLE`, and…
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
Comment Actions
LGTM, but let's see if anybody else has any comments. We should definitely get better at working through the TODO LLVM <version>s.
Comment Actions
Agreed. I'm in no rush to ship this, but it would be good to do it before we cut the LLVM 16 release soon (1/23 I think?)
Comment Actions
Nice catch, thanks!
The CI needs a bit of love right now but I think none of the failures are related.