This is an archive of the discontinued LLVM Phabricator instance.

[libc++] Remove warning for `LIBCXX_SYSROOT`, `LIBCXX_TARGET_TRIPLE`, and `LIBCXX_GCC_TOOLCHAIN`
ClosedPublic

Authored by jloser on Jan 9 2023, 7:16 PM.

Details

Summary

Support for these CMake variables has been a warning for a while now. The
comment indicates to just remove the warning message entirely as anyone impacted
had to have update to new mechanisms in order to use libc++. So, remove the
warning message.

Diff Detail

Event Timeline

jloser created this revision.Jan 9 2023, 7:16 PM
Herald added a project: Restricted Project. · View Herald TranscriptJan 9 2023, 7:16 PM
jloser requested review of this revision.Jan 9 2023, 7:16 PM
Herald added a project: Restricted Project. · View Herald TranscriptJan 9 2023, 7:16 PM
Herald added a reviewer: Restricted Project. · View Herald Transcript
philnik accepted this revision as: philnik.Jan 9 2023, 7:36 PM
philnik added a subscriber: philnik.

LGTM, but let's see if anybody else has any comments. We should definitely get better at working through the TODO LLVM <version>s.

jloser added a comment.Jan 9 2023, 8:10 PM

LGTM, but let's see if anybody else has any comments. We should definitely get better at working through the TODO LLVM <version>s.

Agreed. I'm in no rush to ship this, but it would be good to do it before we cut the LLVM 16 release soon (1/23 I think?)

ldionne accepted this revision.Jan 10 2023, 10:06 AM

Nice catch, thanks!

The CI needs a bit of love right now but I think none of the failures are related.

This revision is now accepted and ready to land.Jan 10 2023, 10:06 AM
This revision was landed with ongoing or failed builds.Jan 10 2023, 12:07 PM
This revision was automatically updated to reflect the committed changes.