This is an archive of the discontinued LLVM Phabricator instance.

Differential D141284

[libc++][test] Fix missing include in `bit_ceil.fail.cpp`
ClosedPublic

Authored by jloser on Jan 9 2023, 7:14 AM.

Details

Reviewers
philnik
Mordante
Group Reviewers
Restricted Project
Commits
rG835cf3ca6bee: [libc++][test] Fix missing include in `bit_ceil.fail.cpp`
Summary

The test uses size_t but does not include a header defining it. Include
<cstddef> which provides size_t.

Diff Detail

Unit TestsFailed

TimeTest
5,240 mslibcxx CI Modular build > llvm-libc++-shared-cfg-in.std/utilities/format/format_functions::ascii.pass.cpp
10,290 mslibcxx CI Modular build > llvm-libc++-shared-cfg-in.std/utilities/format/format_functions::escaped_output.ascii.pass.cpp

Event Timeline

jloser created this revision.Jan 9 2023, 7:14 AM
Herald added a project: Restricted Project. · View Herald TranscriptJan 9 2023, 7:14 AM
jloser requested review of this revision.Jan 9 2023, 7:14 AM
Herald added a project: Restricted Project. · View Herald TranscriptJan 9 2023, 7:14 AM
Herald added a reviewer: Restricted Project. · View Herald Transcript
Herald added a subscriber: libcxx-commits. · View Herald Transcript
jloser mentioned this in D141238: [libc++][test] Move `common_input_iterator` to `test_iterators.h`.Jan 9 2023, 7:16 AM
philnik accepted this revision.Jan 9 2023, 7:27 AM

Thanks for the fixes.

This revision is now accepted and ready to land.Jan 9 2023, 7:27 AM
This revision was landed with ongoing or failed builds.Jan 9 2023, 7:33 AM
Closed by commit rG835cf3ca6bee: [libc++][test] Fix missing include in `bit_ceil.fail.cpp` (authored by jloser). · Explain Why
This revision was automatically updated to reflect the committed changes.
jloser added a commit: rG835cf3ca6bee: [libc++][test] Fix missing include in `bit_ceil.fail.cpp`.
Harbormaster completed remote builds in B206530: Diff 487423.Jan 9 2023, 7:40 AM

Revision Contents

PathSize
libcxx/
test/
std/
numerics/
bit/
bit.pow.two/
3 lines

Diff 487423

libcxx/test/std/numerics/bit/bit.pow.two/bit_ceil.fail.cpp

Show All 9 Lines
// template <class T> // template <class T>
// constexpr T bit_ceil(T x) noexcept; // constexpr T bit_ceil(T x) noexcept;
// Remarks: This function shall not participate in overload resolution unless // Remarks: This function shall not participate in overload resolution unless
// T is an unsigned integer type // T is an unsigned integer type
#include <bit> #include <bit>
#include <cassert>
#include <cstddef>
#include <cstdint> #include <cstdint>
#include <limits> #include <limits>
#include <cassert>
#include "test_macros.h" #include "test_macros.h"
class A{}; class A{};
enum E1 : unsigned char { rEd }; enum E1 : unsigned char { rEd };
enum class E2 : unsigned char { red }; enum class E2 : unsigned char { red };
template <typename T> template <typename T>
Show All 24 Lines