This is an archive of the discontinued LLVM Phabricator instance.

Differential D141169

[libc] Add a gcc fullbuild builder.
ClosedPublic

Authored by sivachandra on Jan 6 2023, 4:16 PM.

Details

Reviewers
gkistanova
Commits
rZORG60df46036d65: [libc] Add a gcc fullbuild builder.

Diff Detail

Event Timeline

sivachandra created this revision.Jan 6 2023, 4:16 PM
Herald added a project: Restricted Project. · View Herald TranscriptJan 6 2023, 4:16 PM
Herald added subscribers: ecnelises, tschuett. · View Herald Transcript
sivachandra requested review of this revision.Jan 6 2023, 4:16 PM
Harbormaster completed remote builds in B206215: Diff 487010.Jan 6 2023, 4:16 PM
gkistanova added a comment.EditedJan 8 2023, 11:17 PM

The patch looks good.

You didn’t add it to the status.py for notifications. Is this intentional?

sivachandra updated this revision to Diff 487308.Jan 9 2023, 12:24 AM

Enable status notifications to the new builder.

Harbormaster completed remote builds in B206448: Diff 487308.Jan 9 2023, 12:24 AM
sivachandra added a comment.Jan 9 2023, 12:25 AM
In D141169#4035231, @gkistanova wrote:

The patch looks good.

You didn’t add it to the status.Oy for notifications. Is this intentional?

Thanks for catching it, I have now added the new builder to status notification list.

gkistanova accepted this revision.Jan 9 2023, 1:37 AM

LGTM.

This revision is now accepted and ready to land.Jan 9 2023, 1:37 AM
Closed by commit rZORG60df46036d65: [libc] Add a gcc fullbuild builder. (authored by sivachandra). · Explain WhyJan 11 2023, 3:34 PM
This revision was automatically updated to reflect the committed changes.
sivachandra added a commit: rZORG60df46036d65: [libc] Add a gcc fullbuild builder..

Revision Contents

PathSize
buildbot/
osuosl/
master/
config/
9 lines

Diff 487010

buildbot/osuosl/master/config/builders.py

Show First 20 Lines • Show All 1,997 Lines • ▼ Show 20 Lines# libc Builders.
'tags' : ["libc"], 'tags' : ["libc"],
'workernames' : ["libc-x86_64-debian-fullbuild"], 'workernames' : ["libc-x86_64-debian-fullbuild"],
'builddir': "libc-x86_64-debian-fullbuild-dbg", 'builddir': "libc-x86_64-debian-fullbuild-dbg",
'factory' : AnnotatedBuilder.getAnnotatedBuildFactory( 'factory' : AnnotatedBuilder.getAnnotatedBuildFactory(
script="libc-linux.py", script="libc-linux.py",
depends_on_projects=['llvm', 'libc', 'clang', 'clang-tools-extra'], depends_on_projects=['llvm', 'libc', 'clang', 'clang-tools-extra'],
extra_args=['--debug'])}, extra_args=['--debug'])},
{'name' : "libc-x86_64-debian-gcc-fullbuild-dbg",
'tags' : ["libc"],
'workernames' : ["libc-x86_64-debian-fullbuild"],
'builddir': "libc-x86_64-debian-gcc-fullbuild-dbg",
'factory' : AnnotatedBuilder.getAnnotatedBuildFactory(
script="libc-linux.py",
depends_on_projects=['llvm', 'libc', 'clang', 'clang-tools-extra'],
extra_args=['--debug'])},
{'name' : "libc-x86_64-debian-fullbuild-dbg-asan", {'name' : "libc-x86_64-debian-fullbuild-dbg-asan",
'tags' : ["libc"], 'tags' : ["libc"],
'workernames' : ["libc-x86_64-debian-fullbuild"], 'workernames' : ["libc-x86_64-debian-fullbuild"],
'builddir': "libc-x86_64-debian-fullbuild-dbg-asan", 'builddir': "libc-x86_64-debian-fullbuild-dbg-asan",
'factory' : AnnotatedBuilder.getAnnotatedBuildFactory( 'factory' : AnnotatedBuilder.getAnnotatedBuildFactory(
script="libc-linux.py", script="libc-linux.py",
depends_on_projects=['llvm', 'libc', 'clang', 'clang-tools-extra'], depends_on_projects=['llvm', 'libc', 'clang', 'clang-tools-extra'],
extra_args=['--debug', '--asan'])}, extra_args=['--debug', '--asan'])},
▲ Show 20 Lines • Show All 732 Lines • Show Last 20 Lines