This is an archive of the discontinued LLVM Phabricator instance.

Differential D141076

[X86] Add additional tests to no-shift.ll
ClosedPublic

Authored by goldstein.w.n on Jan 5 2023, 10:44 AM.

Details

Reviewers
pengfei
lebedev.ri
Commits
rGa698790c51ec: [X86] Add additional tests to no-shift.ll

Diff Detail

Event Timeline

goldstein.w.n created this revision.Jan 5 2023, 10:44 AM
Herald added a project: Restricted Project. · View Herald TranscriptJan 5 2023, 10:44 AM
Herald added a subscriber: pengfei. · View Herald Transcript
goldstein.w.n requested review of this revision.Jan 5 2023, 10:44 AM
Herald added a project: Restricted Project. · View Herald TranscriptJan 5 2023, 10:44 AM
Herald added a subscriber: llvm-commits. · View Herald Transcript
goldstein.w.n added a child revision: D140087: [X86] Replace (31/63 -/^ X) with (NOT X) and ignore (32/64 ^ X) when computing shift count.Jan 5 2023, 10:45 AM
goldstein.w.n added reviewers: pengfei, lebedev.ri.
goldstein.w.n mentioned this in D140087: [X86] Replace (31/63 -/^ X) with (NOT X) and ignore (32/64 ^ X) when computing shift count.
Harbormaster completed remote builds in B205950: Diff 486627.Jan 5 2023, 12:13 PM
pengfei accepted this revision.Jan 5 2023, 6:22 PM

LGTM. Do you want me to commit it for you?

This revision is now accepted and ready to land.Jan 5 2023, 6:22 PM
goldstein.w.n added a comment.Jan 5 2023, 10:03 PM
In D141076#4030347, @pengfei wrote:

LGTM. Do you want me to commit it for you?

Yes, thank you!

This revision was landed with ongoing or failed builds.Jan 5 2023, 10:45 PM
Closed by commit rGa698790c51ec: [X86] Add additional tests to no-shift.ll (authored by goldstein.w.n, committed by pengfei). · Explain Why
This revision was automatically updated to reflect the committed changes.
pengfei added a commit: rGa698790c51ec: [X86] Add additional tests to no-shift.ll.

Revision Contents

PathSize
llvm/
test/
CodeGen/
X86/
69 lines

Diff 486750

llvm/test/CodeGen/X86/not-shift.ll

Show First 20 Lines • Show All 635 Lines • ▼ Show 20 Lines
; X64-BMI2: # %bb.0: ; X64-BMI2: # %bb.0:
; X64-BMI2-NEXT: notb %sil ; X64-BMI2-NEXT: notb %sil
; X64-BMI2-NEXT: shrxl %esi, %edi, %eax ; X64-BMI2-NEXT: shrxl %esi, %edi, %eax
; X64-BMI2-NEXT: retq ; X64-BMI2-NEXT: retq
%adjcnt = xor i32 %cnt, -1 %adjcnt = xor i32 %cnt, -1
%result = lshr i32 %val, %adjcnt %result = lshr i32 %val, %adjcnt
ret i32 %result ret i32 %result
} }
define i32 @invalid_sub31(i32 %val, i32 %cnt) nounwind {
; X86-NOBMI2-LABEL: invalid_sub31:
; X86-NOBMI2: # %bb.0:
; X86-NOBMI2-NEXT: movl {{[0-9]+}}(%esp), %eax
; X86-NOBMI2-NEXT: movzbl {{[0-9]+}}(%esp), %ecx
; X86-NOBMI2-NEXT: addb $-31, %cl
; X86-NOBMI2-NEXT: shll %cl, %eax
; X86-NOBMI2-NEXT: retl
;
; X86-BMI2-LABEL: invalid_sub31:
; X86-BMI2: # %bb.0:
; X86-BMI2-NEXT: movzbl {{[0-9]+}}(%esp), %eax
; X86-BMI2-NEXT: addb $-31, %al
; X86-BMI2-NEXT: shlxl %eax, {{[0-9]+}}(%esp), %eax
; X86-BMI2-NEXT: retl
;
; X64-NOBMI2-LABEL: invalid_sub31:
; X64-NOBMI2: # %bb.0:
; X64-NOBMI2-NEXT: # kill: def $esi killed $esi def $rsi
; X64-NOBMI2-NEXT: movl %edi, %eax
; X64-NOBMI2-NEXT: leal -31(%rsi), %ecx
; X64-NOBMI2-NEXT: # kill: def $cl killed $cl killed $ecx
; X64-NOBMI2-NEXT: shll %cl, %eax
; X64-NOBMI2-NEXT: retq
;
; X64-BMI2-LABEL: invalid_sub31:
; X64-BMI2: # %bb.0:
; X64-BMI2-NEXT: addb $-31, %sil
; X64-BMI2-NEXT: shlxl %esi, %edi, %eax
; X64-BMI2-NEXT: retq
%adjcnt = sub i32 %cnt, 31
%result = shl i32 %val, %adjcnt
ret i32 %result
}
define i32 @invalid_add31(i32 %val, i32 %cnt) nounwind {
; X86-NOBMI2-LABEL: invalid_add31:
; X86-NOBMI2: # %bb.0:
; X86-NOBMI2-NEXT: movl {{[0-9]+}}(%esp), %eax
; X86-NOBMI2-NEXT: movzbl {{[0-9]+}}(%esp), %ecx
; X86-NOBMI2-NEXT: addb $31, %cl
; X86-NOBMI2-NEXT: shll %cl, %eax
; X86-NOBMI2-NEXT: retl
;
; X86-BMI2-LABEL: invalid_add31:
; X86-BMI2: # %bb.0:
; X86-BMI2-NEXT: movzbl {{[0-9]+}}(%esp), %eax
; X86-BMI2-NEXT: addb $31, %al
; X86-BMI2-NEXT: shlxl %eax, {{[0-9]+}}(%esp), %eax
; X86-BMI2-NEXT: retl
;
; X64-NOBMI2-LABEL: invalid_add31:
; X64-NOBMI2: # %bb.0:
; X64-NOBMI2-NEXT: # kill: def $esi killed $esi def $rsi
; X64-NOBMI2-NEXT: movl %edi, %eax
; X64-NOBMI2-NEXT: leal 31(%rsi), %ecx
; X64-NOBMI2-NEXT: # kill: def $cl killed $cl killed $ecx
; X64-NOBMI2-NEXT: shll %cl, %eax
; X64-NOBMI2-NEXT: retq
;
; X64-BMI2-LABEL: invalid_add31:
; X64-BMI2: # %bb.0:
; X64-BMI2-NEXT: addb $31, %sil
; X64-BMI2-NEXT: shlxl %esi, %edi, %eax
; X64-BMI2-NEXT: retq
%adjcnt = add i32 %cnt, 31
%result = shl i32 %val, %adjcnt
ret i32 %result
}