This is an archive of the discontinued LLVM Phabricator instance.

Differential D141024

[lld-macho][test] Simplify classrefs test
ClosedPublic

Authored by int3 on Jan 4 2023, 7:53 PM.

Details

Reviewers
thakis
Group Reviewers
Restricted Project
Commits
rG4228ab009fa7: [lld-macho][test] Simplify classrefs test
Summary

I wasn't previously aware of the --objc-meta-data flag; that makes
llvm-objdump's output a lot easier to parse.

Diff Detail

Event Timeline

int3 created this revision.Jan 4 2023, 7:53 PM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptJan 4 2023, 7:53 PM
int3 requested review of this revision.Jan 4 2023, 7:53 PM
Herald added a project: Restricted Project. · View Herald TranscriptJan 4 2023, 7:53 PM
Herald added a subscriber: llvm-commits. · View Herald Transcript
Harbormaster completed remote builds in B205821: Diff 486452.Jan 4 2023, 8:07 PM
thakis accepted this revision.Jan 5 2023, 9:53 AM
thakis added a subscriber: thakis.

lg

lld/test/MachO/objc-classrefs-dedup.s
8

nit: consider llvm-otool -o instead (does the same thing, just shorter)

This revision is now accepted and ready to land.Jan 5 2023, 9:53 AM
Closed by commit rG4228ab009fa7: [lld-macho][test] Simplify classrefs test (authored by int3). · Explain WhyJan 5 2023, 10:30 AM
This revision was automatically updated to reflect the committed changes.
int3 added a commit: rG4228ab009fa7: [lld-macho][test] Simplify classrefs test.
int3 marked an inline comment as done.Jan 5 2023, 10:30 AM

Revision Contents

PathSize
lld/
test/
MachO/
22 lines

Diff 486452

lld/test/MachO/objc-classrefs-dedup.s

# REQUIRES: x86 # REQUIRES: x86
# RUN: rm -rf %t; split-file %s %t # RUN: rm -rf %t; split-file %s %t
# RUN: llvm-mc -filetype=obj -triple=x86_64-apple-darwin %t/defs.s -o %t/defs.o # RUN: llvm-mc -filetype=obj -triple=x86_64-apple-darwin %t/defs.s -o %t/defs.o
# RUN: llvm-mc -filetype=obj -triple=x86_64-apple-darwin %t/refs1.s -o %t/refs1.o # RUN: llvm-mc -filetype=obj -triple=x86_64-apple-darwin %t/refs1.s -o %t/refs1.o
# RUN: llvm-mc -filetype=obj -triple=x86_64-apple-darwin %t/refs2.s -o %t/refs2.o # RUN: llvm-mc -filetype=obj -triple=x86_64-apple-darwin %t/refs2.s -o %t/refs2.o
# RUN: %lld -lSystem -dylib %t/defs.o -o %t/libdefs.dylib # RUN: %lld -lSystem -dylib %t/defs.o -o %t/libdefs.dylib
# RUN: %lld -lSystem -dylib --icf=all %t/refs1.o %t/refs2.o %t/libdefs.dylib -o %t/out # RUN: %lld -lSystem -dylib --icf=all %t/refs1.o %t/refs2.o %t/libdefs.dylib -o %t/out
# RUN: llvm-objdump --macho --section-headers --bind %t/out | FileCheck %s \ # RUN: llvm-objdump --macho --objc-meta-data %t/out | FileCheck %s
thakisUnsubmitted
Done
ReplyInline Actions

nit: consider llvm-otool -o instead (does the same thing, just shorter)

thakis: nit: consider `llvm-otool -o` instead (does the same thing, just shorter)
# RUN: --implicit-check-not __objc_classrefs
## Check that we only have 3 (unique) entries ## Check that we only have 3 (unique) entries, of which two are bound at runtime
# CHECK: Sections: ## (i.e. they are entries that have a static value of 0x0).
# CHECK-NEXT: Idx Name Size # CHECK: Contents of (__DATA,__objc_classrefs) section
# CHECK: __objc_classrefs 00000018 # CHECK-NEXT: 0000000000001008 0x0 _OBJC_CLASS_$_Foo
# CHECK-NEXT: 0000000000001010 0x0 _OBJC_CLASS_$_Bar
## And only two binds # CHECK-NEXT: 0000000000001018 0x1000 _OBJC_CLASS_$_Baz
# CHECK: Bind table: # CHECK-EMPTY:
# CHECK-NEXT: segment section address type addend dylib symbol
# CHECK-DAG: __DATA __objc_classrefs {{.*}} pointer 0 libdefs _OBJC_CLASS_$_Bar
# CHECK-DAG: __DATA __objc_classrefs {{.*}} pointer 0 libdefs _OBJC_CLASS_$_Foo
#--- defs.s #--- defs.s
.globl _OBJC_CLASS_$_Foo, _OBJC_CLASS_$_Bar .globl _OBJC_CLASS_$_Foo, _OBJC_CLASS_$_Bar
.section __DATA,__objc_data .section __DATA,__objc_data
_OBJC_CLASS_$_Foo: _OBJC_CLASS_$_Foo:
.quad 123 .quad 123
_OBJC_CLASS_$_Bar: _OBJC_CLASS_$_Bar:
Show All 25 Lines