Paths

Table of Contentst

[LoopUnrollAndJam] Forget scalar evolution dispositions. Do no explicitly forget subloop.
ClosedPublic
Actions

Authored by caojoshua on Jan 3 2023, 11:02 PM.

Details

Reviewers

fhahn
dmgreen

Commits

rG50be2859443a: [LoopUnrollAndJam] Forget scalar evolution dispositions. Do no explicitly…

Summary

Fixes https://github.com/llvm/llvm-project/issues/58454

Scalar evolution dispositions need to be forgotten to pass verification.

We do not need to forget the subloop since it is automatically forgotten
when forgetting the parent loop.

Diff Detail

Repository: rG LLVM Github Monorepo

Event Timeline

caojoshua created this revision.Jan 3 2023, 11:02 PM

Herald added a project: Restricted Project. · View Herald TranscriptJan 3 2023, 11:02 PM

Herald added subscribers: zzheng, hiraditya. · View Herald Transcript

caojoshua published this revision for review.Jan 3 2023, 11:04 PM

caojoshua added reviewers: fhahn, dmgreen.

Herald added a project: Restricted Project. · View Herald TranscriptJan 3 2023, 11:04 PM

Herald added a subscriber: llvm-commits. · View Herald Transcript

Harbormaster completed remote builds in B205604: Diff 486167.Jan 3 2023, 11:44 PM

Add -verify-scev to test

Harbormaster completed remote builds in B205615: Diff 486181.Jan 4 2023, 1:18 AM

LGTM, thanks!

llvm/test/Transforms/LoopUnrollAndJam/se-forget.ll
3	IIUC `print<scalar-evolution>` is only needed to populate the SCEV caches. Might be good to ad d a note.

This revision is now accepted and ready to land.Jan 4 2023, 7:02 AM

Added note that print<scalar-evolution> is used to populate scev caches

Added suggested note that print<scalar-evolution> is needed to populate scev caches. I don't have commit access right now. I sent a request today, but can I get help merging this for now?

Harbormaster completed remote builds in B205807: Diff 486434.Jan 4 2023, 6:46 PM

Closed by commit rG50be2859443a: [LoopUnrollAndJam] Forget scalar evolution dispositions. Do no explicitly… (authored by caojoshua). · Explain WhyJan 4 2023, 7:56 PM

This revision was automatically updated to reflect the committed changes.

caojoshua added a commit: rG50be2859443a: [LoopUnrollAndJam] Forget scalar evolution dispositions. Do no explicitly….

Revision Contents
Changeset List

Path

Size

llvm/

lib/

Transforms/

Utils/

LoopUnrollAndJam.cpp

2 lines

test/

Transforms/

LoopUnrollAndJam/

se-forget.ll

125 lines

Diff 486455

View Options

llvm/lib/Transforms/Utils/LoopUnrollAndJam.cpp