This is an archive of the discontinued LLVM Phabricator instance.

Differential D140923

tsan: increase app mappings for aarch64 48-bit
ClosedPublic

Authored by thurston on Jan 3 2023, 1:48 PM.

Details

Reviewers
dvyukov
vitalybuka
eugenis
Commits
rGdf3af581e711: tsan: increase app mappings for aarch64 48-bit
Summary

Currently, tsan's memory mappings include 4GB
for high app, 20GB for mid app, and 8GB for low
app. The high app and mid app mappings are
too small for large programs, especially if ASLR
entropy (mmap_rnd_bits) is set higher. The low app
region (for non-PIE) is too small for some of tcmalloc's
internal tests (this does not affect normal apps,
since tsan will replace malloc).

This CL increases the memory mappings to 4TB for
high app, 1.3TB for mid app, and 10TB for low app. Note
that tsan's 44-bit pointer compression/decompression imposes
a 16TB limit on the combined size of the app mappings, making
this set of mappings more or less maximal.

Diff Detail

Event Timeline

thurston created this revision.Jan 3 2023, 1:48 PM
Herald added a project: Restricted Project. · View Herald TranscriptJan 3 2023, 1:48 PM
Herald added subscribers: Enna1, kristof.beyls. · View Herald Transcript
thurston requested review of this revision.Jan 3 2023, 1:48 PM
Herald added a project: Restricted Project. · View Herald TranscriptJan 3 2023, 1:48 PM
Herald added a subscriber: Restricted Project. · View Herald Transcript
thurston added reviewers: dvyukov, vitalybuka.Jan 3 2023, 1:50 PM
thurston added a reviewer: eugenis.Jan 3 2023, 1:54 PM
Harbormaster completed remote builds in B205525: Diff 486072.Jan 3 2023, 2:10 PM
dvyukov accepted this revision.Jan 8 2023, 10:53 PM

Rubber stamp if mapping tests pass.

This revision is now accepted and ready to land.Jan 8 2023, 10:53 PM
This revision was landed with ongoing or failed builds.Jan 9 2023, 10:53 AM
Closed by commit rGdf3af581e711: tsan: increase app mappings for aarch64 48-bit (authored by thurston). · Explain Why
This revision was automatically updated to reflect the committed changes.
thurston added a commit: rGdf3af581e711: tsan: increase app mappings for aarch64 48-bit.

Revision Contents

PathSize
compiler-rt/
lib/
tsan/
rtl/
24 lines

Diff 487497

compiler-rt/lib/tsan/rtl/tsan_platform.h

Show First 20 Lines • Show All 206 Lines • ▼ Show 20 Linesstruct MappingAarch64_42 {
static const uptr kShadowMsk = 0x3c000000000ull; static const uptr kShadowMsk = 0x3c000000000ull;
static const uptr kShadowXor = 0x04000000000ull; static const uptr kShadowXor = 0x04000000000ull;
static const uptr kShadowAdd = 0x00000000000ull; static const uptr kShadowAdd = 0x00000000000ull;
static const uptr kVdsoBeg = 0x37f00000000ull; static const uptr kVdsoBeg = 0x37f00000000ull;
}; };
struct MappingAarch64_48 { struct MappingAarch64_48 {
static const uptr kLoAppMemBeg = 0x0000000001000ull; static const uptr kLoAppMemBeg = 0x0000000001000ull;
static const uptr kLoAppMemEnd = 0x0000200000000ull; static const uptr kLoAppMemEnd = 0x00a0000000000ull;
static const uptr kShadowBeg = 0x0001000000000ull; static const uptr kShadowBeg = 0x0155400000000ull;
static const uptr kShadowEnd = 0x0002000000000ull; static const uptr kShadowEnd = 0x0540000000000ull;
static const uptr kMetaShadowBeg = 0x0005000000000ull; static const uptr kMetaShadowBeg = 0x0800000000000ull;
static const uptr kMetaShadowEnd = 0x0006000000000ull; static const uptr kMetaShadowEnd = 0x0a00000000000ull;
static const uptr kMidAppMemBeg = 0x0aaaa00000000ull; static const uptr kMidAppMemBeg = 0x0aaaa00000000ull;
static const uptr kMidAppMemEnd = 0x0aaaf00000000ull; static const uptr kMidAppMemEnd = 0x0ac0000000000ull;
static const uptr kHeapMemBeg = 0x0ffff00000000ull; static const uptr kHiAppMemBeg = 0x0fc0000000000ull;
static const uptr kHeapMemEnd = 0x0ffff00000000ull;
static const uptr kHiAppMemBeg = 0x0ffff00000000ull;
static const uptr kHiAppMemEnd = 0x1000000000000ull; static const uptr kHiAppMemEnd = 0x1000000000000ull;
static const uptr kShadowMsk = 0x0fff800000000ull; static const uptr kHeapMemBeg = 0x0fc0000000000ull;
static const uptr kShadowXor = 0x0000800000000ull; static const uptr kHeapMemEnd = 0x0fc0000000000ull;
static const uptr kShadowMsk = 0x0c00000000000ull;
static const uptr kShadowXor = 0x0200000000000ull;
static const uptr kShadowAdd = 0x0000000000000ull; static const uptr kShadowAdd = 0x0000000000000ull;
static const uptr kVdsoBeg = 0xffff000000000ull; static const uptr kVdsoBeg = 0xffff000000000ull;
}; };
/* C/C++ on linux/loongarch64 (47-bit VMA) /* C/C++ on linux/loongarch64 (47-bit VMA)
0000 0000 4000 - 0080 0000 0000: main binary 0000 0000 4000 - 0080 0000 0000: main binary
0080 0000 0000 - 0100 0000 0000: - 0080 0000 0000 - 0100 0000 0000: -
0100 0000 0000 - 1000 0000 0000: shadow memory 0100 0000 0000 - 1000 0000 0000: shadow memory
1000 0000 0000 - 3000 0000 0000: - 1000 0000 0000 - 3000 0000 0000: -
▲ Show 20 Lines • Show All 681 Lines • Show Last 20 Lines