This is an archive of the discontinued LLVM Phabricator instance.

Differential D140854

Fix typo in llvm/test/Transforms/LoopUnroll/runtime-loop1.ll
AcceptedPublic

Authored by zzheng on Jan 2 2023, 12:47 PM.

Details

Reviewers
lebedev.ri
echristo
Summary

Removing duplicated definintion of variable PH_LOC.

Diff Detail

Unit TestsFailed

TimeTest
60,060 msx64 debian > Clang.Driver::emit-reproducer.c
60,350 msx64 debian > Clang.Driver::fsanitize.c
60,020 msx64 debian > libFuzzer.libFuzzer::minimize_crash.test

Event Timeline

zzheng created this revision.Jan 2 2023, 12:47 PM
Herald added a project: Restricted Project. · View Herald TranscriptJan 2 2023, 12:47 PM
zzheng requested review of this revision.Jan 2 2023, 12:47 PM
Herald added a project: Restricted Project. · View Herald TranscriptJan 2 2023, 12:47 PM
Herald added a subscriber: llvm-commits. · View Herald Transcript
Harbormaster completed remote builds in B205373: Diff 485881.Jan 2 2023, 1:33 PM
lebedev.ri accepted this revision.Jan 15 2023, 5:17 PM

Seems like an obvious typo to me, assuming the test still passes.

This revision is now accepted and ready to land.Jan 15 2023, 5:17 PM
Herald added a subscriber: StephenFan. · View Herald TranscriptJan 15 2023, 5:17 PM

Revision Contents

PathSize
llvm/
test/
Transforms/
LoopUnroll/
2 lines

Diff 485881

llvm/test/Transforms/LoopUnroll/runtime-loop1.ll

Show All 19 Lines
; EPILOG: br label %for.end, !dbg [[EXIT_LOC]] ; EPILOG: br label %for.end, !dbg [[EXIT_LOC]]
; EPILOG-DAG: [[PH_LOC]] = !DILocation(line: 102, column: 1, scope: !{{.*}}) ; EPILOG-DAG: [[PH_LOC]] = !DILocation(line: 102, column: 1, scope: !{{.*}})
; EPILOG-DAG: [[EXIT_LOC]] = !DILocation(line: 103, column: 1, scope: !{{.*}}) ; EPILOG-DAG: [[EXIT_LOC]] = !DILocation(line: 103, column: 1, scope: !{{.*}})
; PROLOG: for.body.preheader: ; PROLOG: for.body.preheader:
; PROLOG: br {{.*}} label %for.body.prol.preheader, label %for.body.prol.loopexit, !dbg [[PH_LOC:![0-9]+]] ; PROLOG: br {{.*}} label %for.body.prol.preheader, label %for.body.prol.loopexit, !dbg [[PH_LOC:![0-9]+]]
; PROLOG: for.body.prol: ; PROLOG: for.body.prol:
; PROLOG: br label %for.body.prol.loopexit, !dbg [[PH_LOC:![0-9]+]] ; PROLOG: br label %for.body.prol.loopexit, !dbg [[PH_LOC]]
; PROLOG: for.body.prol.loopexit: ; PROLOG: for.body.prol.loopexit:
; PROLOG: br {{.*}} label %for.end.loopexit, label %for.body.preheader.new, !dbg [[PH_LOC]] ; PROLOG: br {{.*}} label %for.end.loopexit, label %for.body.preheader.new, !dbg [[PH_LOC]]
; PROLOG: for.body: ; PROLOG: for.body:
; PROLOG: br i1 %exitcond.1, label %for.end.loopexit.unr-lcssa, label %for.body, !dbg [[PH_LOC]] ; PROLOG: br i1 %exitcond.1, label %for.end.loopexit.unr-lcssa, label %for.body, !dbg [[PH_LOC]]
; PROLOG-NOT: br i1 %exitcond.4, label %for.end.loopexit{{.*}}, label %for.body ; PROLOG-NOT: br i1 %exitcond.4, label %for.end.loopexit{{.*}}, label %for.body
; PROLOG-DAG: [[PH_LOC]] = !DILocation(line: 102, column: 1, scope: !{{.*}}) ; PROLOG-DAG: [[PH_LOC]] = !DILocation(line: 102, column: 1, scope: !{{.*}})
Show All 39 Lines