This is an archive of the discontinued LLVM Phabricator instance.

Differential D140810

[OpenMP][libomptarget] Add TargetParser as dependency in NextGen's JIT
ClosedPublic

Authored by kevinsala on Dec 31 2022, 12:26 PM.

Details

Reviewers
tianshilei1992
jdoerfert
Commits
rG339d810a0fcc: [OpenMP][libomptarget] Add TargetParser as dependency in NextGen's JIT
Summary

This fixes an undefined symbol of llvm::Triple::Triple() constructor when building the NextGen plugins:

openmp/libomptarget/plugins-nextgen/common/PluginInterface/JIT.cpp:343: undefined reference to `llvm::Triple::Triple(llvm::Twine const&)'

Although the patch makes the error to disappear on my side, I'm opening this review since I'm not 100% sure whether this is a complete fix.

Diff Detail

Event Timeline

kevinsala created this revision.Dec 31 2022, 12:26 PM
Herald added a project: Restricted Project. · View Herald TranscriptDec 31 2022, 12:26 PM
Herald added subscribers: guansong, yaxunl. · View Herald Transcript
kevinsala requested review of this revision.Dec 31 2022, 12:26 PM
Herald added subscribers: openmp-commits, sstefan1. · View Herald TranscriptDec 31 2022, 12:26 PM
kevinsala edited the summary of this revision. (Show Details)Dec 31 2022, 12:27 PM
Harbormaster completed remote builds in B205291: Diff 485785.Dec 31 2022, 12:30 PM
tianshilei1992 accepted this revision.Dec 31 2022, 8:39 PM

LG

This revision is now accepted and ready to land.Dec 31 2022, 8:39 PM
Closed by commit rG339d810a0fcc: [OpenMP][libomptarget] Add TargetParser as dependency in NextGen's JIT (authored by kevinsala). · Explain WhyJan 1 2023, 4:32 AM
This revision was automatically updated to reflect the committed changes.
kevinsala added a commit: rG339d810a0fcc: [OpenMP][libomptarget] Add TargetParser as dependency in NextGen's JIT.

Revision Contents

PathSize
openmp/
libomptarget/
plugins-nextgen/
common/
PluginInterface/
1 line

Diff 485803

openmp/libomptarget/plugins-nextgen/common/PluginInterface/CMakeLists.txt

Show First 20 Lines • Show All 43 Lines • ▼ Show 20 Lines llvm_map_components_to_libnames(llvm_libs
Linker Linker
MC MC
Object Object
Passes Passes
Remarks Remarks
ScalarOpts ScalarOpts
Support Support
Target Target
TargetParser
TransformUtils TransformUtils
Vectorize Vectorize
) )
endif() endif()
target_link_libraries(PluginInterface target_link_libraries(PluginInterface
PUBLIC PUBLIC
${llvm_libs} ${llvm_libs}
Show All 18 Lines