[clang] Fix unused variable warning in SemaConcept.cpp

[vctr]

Summary

Issue is described here: https://github.com/llvm/llvm-project/issues/59696

[vctr]

Hey @hokein, thanks for the accept. I don't have commit rights, can you please land this?

[cor3ntin]

nit: I think that's a cleaner fix :)

clang/lib/Sema/SemaConcept.cpp

1349

[hokein]

clang/lib/Sema/SemaConcept.cpp

1349

we still need the FD1 as there is a IsExpectedEntity(FD1) call in the assert on L1358.

[hokein]

Hey @hokein, thanks for the accept. I don't have commit rights, can you please land this?

Done. Sorry for the late response (I totally missed this).

clang/lib/Sema/SemaConcept.cpp

static bool subsumes(Sema &S, NamedDecl *DP, ArrayRef<const Expr *> P,
   return false;
 }
 
 bool Sema::IsAtLeastAsConstrained(NamedDecl *D1,
                                   MutableArrayRef<const Expr *> AC1,
                                   NamedDecl *D2,
                                   MutableArrayRef<const Expr *> AC2,
                                   bool &Result) {
   if (const auto *FD1 = dyn_cast<FunctionDecl>(D1)) {
     auto IsExpectedEntity = [](const FunctionDecl *FD) {
       FunctionDecl::TemplatedKind Kind = FD->getTemplatedKind();
       return Kind == FunctionDecl::TK_NonTemplate ||
              Kind == FunctionDecl::TK_FunctionTemplate;
     };
     const auto *FD2 = dyn_cast<FunctionDecl>(D2);
     (void)IsExpectedEntity;
+    (void)FD1;
     (void)FD2;
     assert(IsExpectedEntity(FD1) && FD2 && IsExpectedEntity(FD2) &&
            "use non-instantiated function declaration for constraints partial "
            "ordering");
   }
 
   if (AC1.empty()) {
     Result = AC2.empty();