This is an archive of the discontinued LLVM Phabricator instance.

[FPEnv Core 05/14] Teach IR builder and folders about new flags
AcceptedPublic

Authored by sdmitrouk on Oct 26 2015, 6:56 AM.

Details

Summary

FastMathFlags were moved to a separate header to make it possible
to use in IR/Constants.h, which otherwise created circular dependency
between IR/Constants.h and IR/Operator.h.

Diff Detail

Repository
rL LLVM

Event Timeline

sdmitrouk updated this revision to Diff 38403.Oct 26 2015, 6:56 AM
sdmitrouk retitled this revision from to [FPEnv Core 05/14] Teach IR builder and folders about new flags.
sdmitrouk updated this object.
sdmitrouk added reviewers: hfinkel, mehdi_amini.
sdmitrouk set the repository for this revision to rL LLVM.
sdmitrouk added subscribers: llvm-commits, scanon, resistor.
majnemer added inline comments.
test/Other/fpenv-constant-fold.ll
10

You need to check the operands here as well.

sdmitrouk updated this revision to Diff 41913.Dec 4 2015, 12:05 PM

Update test as requested, update code due to other changes.

sdmitrouk updated this revision to Diff 42228.Dec 8 2015, 2:26 PM

Some changes are now in D14069, it didn't compile without them. There were too many rebases...

mehdi_amini added inline comments.Dec 11 2015, 3:46 PM
test/Other/fpenv-constant-fold.ll
11

Nit: the second {{.*}} seems spurious.

Also do you expect the nrnd to be dropped?

mehdi_amini accepted this revision.Dec 11 2015, 3:56 PM
mehdi_amini edited edge metadata.
This revision is now accepted and ready to land.Dec 11 2015, 3:56 PM
sdmitrouk updated this revision to Diff 42722.Dec 14 2015, 7:57 AM
sdmitrouk edited edge metadata.
sdmitrouk marked an inline comment as done.

Update test and also one get() invocation, which was changed by mistake (it called itself after this change).

test/Other/fpenv-constant-fold.ll
11

Nit: the second {{.*}} seems spurious.

Right, thanks.

Also do you expect the nrnd to be dropped?

No. Initially I wanted to check only for presence of floating-point instructions, but then added arguments as was requested, now changed to check everything.