This is an archive of the discontinued LLVM Phabricator instance.

Differential D140609

[bugpoint] Fix compilation of bugpoint-passes on Windows
ClosedPublic

Authored by dimula73 on Dec 22 2022, 11:05 PM.

Download Raw Diff

Details

Reviewers

chandlerc
beanz

Commits

rGb0b4cc18641b: [bugpoint] Fix compilation of bugpoint-passes on Windows

Summary

Bugpoint also depends on libLLVMSupport.dll for 'llvm_unreachable'

Diff Detail

Repository: rG LLVM Github Monorepo

Event Timeline

dimula73 created this revision.Dec 22 2022, 11:05 PM

Herald added a project: Restricted Project. · View Herald TranscriptDec 22 2022, 11:05 PM

dimula73 requested review of this revision.Dec 22 2022, 11:05 PM

Herald added a subscriber: llvm-commits. · View Herald TranscriptDec 22 2022, 11:05 PM

Harbormaster completed remote builds in B204737: Diff 485051.Dec 23 2022, 12:02 AM

dimula73 added a reviewer: chandlerc.Dec 27 2022, 10:51 PM

@beanz, could you help with reviewing this change, please?

Yea, this makes sense for Windows. LGTM.

This revision is now accepted and ready to land.Jan 23 2023, 1:31 PM

Closed by commit rGb0b4cc18641b: [bugpoint] Fix compilation of bugpoint-passes on Windows (authored by bader). · Explain WhyJan 23 2023, 5:48 PM

This revision was automatically updated to reflect the committed changes.

bader added a commit: rGb0b4cc18641b: [bugpoint] Fix compilation of bugpoint-passes on Windows.

Revision Contents

Path

Size

llvm/

tools/

bugpoint-passes/

2 lines

Diff 491580

llvm/tools/bugpoint-passes/CMakeLists.txt

	if( NOT LLVM_BUILD_TOOLS )			if( NOT LLVM_BUILD_TOOLS )
	set(EXCLUDE_FROM_ALL ON)			set(EXCLUDE_FROM_ALL ON)
	endif()			endif()

	# If we don't need RTTI or EH, there's no reason to export anything			# If we don't need RTTI or EH, there's no reason to export anything
	# from this plugin.			# from this plugin.
	if( NOT LLVM_REQUIRES_RTTI )			if( NOT LLVM_REQUIRES_RTTI )
	if( NOT LLVM_REQUIRES_EH )			if( NOT LLVM_REQUIRES_EH )
	set(LLVM_EXPORTED_SYMBOL_FILE ${CMAKE_CURRENT_SOURCE_DIR}/bugpoint.exports)			set(LLVM_EXPORTED_SYMBOL_FILE ${CMAKE_CURRENT_SOURCE_DIR}/bugpoint.exports)
	endif()			endif()
	endif()			endif()

	if(WIN32 OR CYGWIN)			if(WIN32 OR CYGWIN)
	set(LLVM_LINK_COMPONENTS Core)			set(LLVM_LINK_COMPONENTS Core Support)
	endif()			endif()

	add_llvm_library( BugpointPasses MODULE BUILDTREE_ONLY			add_llvm_library( BugpointPasses MODULE BUILDTREE_ONLY
	TestPasses.cpp			TestPasses.cpp

	DEPENDS			DEPENDS
	intrinsics_gen			intrinsics_gen
	bugpoint			bugpoint
	)			)