This is an archive of the discontinued LLVM Phabricator instance.

Differential D140424

[libc++] Also install libclang in the Docker image
ClosedPublic

Authored by philnik on Dec 20 2022, 11:36 AM.

Details

Reviewers
Mordante
ldionne
Group Reviewers
Restricted Project
Commits
rG6198f3abf56f: [libc++] Also install libclang in the Docker image
Summary

This is now everything that is required for clang-tidy checks.

Diff Detail

Event Timeline

philnik created this revision.Dec 20 2022, 11:36 AM
Herald added a project: Restricted Project. · View Herald TranscriptDec 20 2022, 11:36 AM
Herald added a subscriber: arichardson. · View Herald Transcript
philnik requested review of this revision.Dec 20 2022, 11:36 AM
Herald added a project: Restricted Project. · View Herald TranscriptDec 20 2022, 11:36 AM
Herald added a reviewer: Restricted Project. · View Herald Transcript
Herald added a subscriber: libcxx-commits. · View Herald Transcript
Harbormaster completed remote builds in B204211: Diff 484336.Dec 20 2022, 1:24 PM
ldionne accepted this revision.Dec 21 2022, 6:18 AM
This revision is now accepted and ready to land.Dec 21 2022, 6:18 AM
This revision was landed with ongoing or failed builds.Dec 21 2022, 6:39 AM
Closed by commit rG6198f3abf56f: [libc++] Also install libclang in the Docker image (authored by philnik). · Explain Why
This revision was automatically updated to reflect the committed changes.
philnik added a commit: rG6198f3abf56f: [libc++] Also install libclang in the Docker image.

Revision Contents

PathSize
libcxx/
utils/
ci/
7 lines

Diff 484566

libcxx/utils/ci/Dockerfile

Show First 20 Lines • Show All 78 Lines • ▼ Show 20 Lines
RUN ln -s /usr/bin/clang-format-14 /usr/bin/clang-format && [ -e $(readlink /usr/bin/clang-format) ] RUN ln -s /usr/bin/clang-format-14 /usr/bin/clang-format && [ -e $(readlink /usr/bin/clang-format) ]
RUN ln -s /usr/bin/git-clang-format-14 /usr/bin/git-clang-format && [ -e $(readlink /usr/bin/git-clang-format) ] RUN ln -s /usr/bin/git-clang-format-14 /usr/bin/git-clang-format && [ -e $(readlink /usr/bin/git-clang-format) ]
# Install clang-tidy # Install clang-tidy
# TODO LLVM 16 remove hard-coded version 14 and the symlink # TODO LLVM 16 remove hard-coded version 14 and the symlink
RUN apt-get update && apt-get install -y clang-tidy-$(($LLVM_HEAD_VERSION - 1)) clang-tidy-$LLVM_HEAD_VERSION clang-tidy-14 RUN apt-get update && apt-get install -y clang-tidy-$(($LLVM_HEAD_VERSION - 1)) clang-tidy-$LLVM_HEAD_VERSION clang-tidy-14
RUN ln -s /usr/bin/clang-tidy-14 /usr/bin/clang-tidy && [ -e $(readlink /usr/bin/clang-tidy) ] RUN ln -s /usr/bin/clang-tidy-14 /usr/bin/clang-tidy && [ -e $(readlink /usr/bin/clang-tidy) ]
# Install llvm-dev to compile custom clang-tidy checks # Install llvm-dev and libclang-dev to compile custom clang-tidy checks
RUN apt-get update && apt-get install llvm-$(($LLVM_HEAD_VERSION - 1))-dev llvm-$(($LLVM_HEAD_VERSION - 2))-dev RUN apt-get update && apt-get install -y llvm-$(($LLVM_HEAD_VERSION - 1))-dev llvm-$(($LLVM_HEAD_VERSION - 2))-dev \
libclang-$(($LLVM_HEAD_VERSION - 1))-dev libclang-$(($LLVM_HEAD_VERSION - 2))-dev
# TODO LLVM16 Don't install llvm-16-dev explicitly # TODO LLVM16 Don't install llvm-16-dev explicitly
RUN apt-get update && apt-get install llvm-16-dev RUN apt-get update && apt-get install -y llvm-16-dev libclang-16-dev
# Install clang-tools # Install clang-tools
RUN apt-get update && apt-get install -y clang-tools-$(($LLVM_HEAD_VERSION - 1)) clang-tools-$LLVM_HEAD_VERSION RUN apt-get update && apt-get install -y clang-tools-$(($LLVM_HEAD_VERSION - 1)) clang-tools-$LLVM_HEAD_VERSION
# Install the most recent GCC, like clang install the previous version as a transition. # Install the most recent GCC, like clang install the previous version as a transition.
ENV GCC_LATEST_VERSION=12 ENV GCC_LATEST_VERSION=12
RUN apt-get update && apt install -y gcc-$((GCC_LATEST_VERSION - 1)) g++-$((GCC_LATEST_VERSION - 1)) RUN apt-get update && apt install -y gcc-$((GCC_LATEST_VERSION - 1)) g++-$((GCC_LATEST_VERSION - 1))
RUN apt-get update && apt install -y gcc-$GCC_LATEST_VERSION g++-$GCC_LATEST_VERSION RUN apt-get update && apt install -y gcc-$GCC_LATEST_VERSION g++-$GCC_LATEST_VERSION
Show All 22 Lines