This is an archive of the discontinued LLVM Phabricator instance.

Differential D140346

[NFC] use bitwise or instead of addition
ClosedPublic

Authored by fmayer on Dec 19 2022, 1:25 PM.

Details

Reviewers
hctim
Commits
rGeddb7280462c: [NFC] use bitwise or instead of addition
Summary

as the bits are all distinct, these two operations have the same result,
but the bitwise operation is more explicit about what's happening.

Diff Detail

Event Timeline

fmayer created this revision.Dec 19 2022, 1:25 PM
Herald added a project: Restricted Project. · View Herald TranscriptDec 19 2022, 1:25 PM
Herald added subscribers: Enna1, hiraditya. · View Herald Transcript
fmayer requested review of this revision.Dec 19 2022, 1:25 PM
Herald added a project: Restricted Project. · View Herald TranscriptDec 19 2022, 1:25 PM
Herald added a subscriber: llvm-commits. · View Herald Transcript
fmayer added a reviewer: hctim.Dec 19 2022, 1:27 PM
hctim accepted this revision.Dec 19 2022, 2:15 PM
This revision is now accepted and ready to land.Dec 19 2022, 2:15 PM
Harbormaster completed remote builds in B203990: Diff 484054.Dec 19 2022, 3:27 PM
Closed by commit rGeddb7280462c: [NFC] use bitwise or instead of addition (authored by fmayer). · Explain WhyDec 19 2022, 3:35 PM
This revision was automatically updated to reflect the committed changes.
fmayer added a commit: rGeddb7280462c: [NFC] use bitwise or instead of addition.

Revision Contents

PathSize
llvm/
lib/
Transforms/
Instrumentation/
10 lines

Diff 484115

llvm/lib/Transforms/Instrumentation/HWAddressSanitizer.cpp

Show First 20 Lines • Show All 812 Lines • ▼ Show 20 LinesValue *HWAddressSanitizer::memToShadow(Value *Mem, IRBuilder<> &IRB) {
if (Mapping.Offset == 0) if (Mapping.Offset == 0)
return IRB.CreateIntToPtr(Shadow, Int8PtrTy); return IRB.CreateIntToPtr(Shadow, Int8PtrTy);
// (Mem >> Scale) + Offset // (Mem >> Scale) + Offset
return IRB.CreateGEP(Int8Ty, ShadowBase, Shadow); return IRB.CreateGEP(Int8Ty, ShadowBase, Shadow);
} }
int64_t HWAddressSanitizer::getAccessInfo(bool IsWrite, int64_t HWAddressSanitizer::getAccessInfo(bool IsWrite,
unsigned AccessSizeIndex) { unsigned AccessSizeIndex) {
return (CompileKernel << HWASanAccessInfo::CompileKernelShift) + return (CompileKernel << HWASanAccessInfo::CompileKernelShift) |
(HasMatchAllTag << HWASanAccessInfo::HasMatchAllShift) + (HasMatchAllTag << HWASanAccessInfo::HasMatchAllShift) |
(MatchAllTag << HWASanAccessInfo::MatchAllShift) + (MatchAllTag << HWASanAccessInfo::MatchAllShift) |
(Recover << HWASanAccessInfo::RecoverShift) + (Recover << HWASanAccessInfo::RecoverShift) |
(IsWrite << HWASanAccessInfo::IsWriteShift) + (IsWrite << HWASanAccessInfo::IsWriteShift) |
(AccessSizeIndex << HWASanAccessInfo::AccessSizeShift); (AccessSizeIndex << HWASanAccessInfo::AccessSizeShift);
} }
void HWAddressSanitizer::instrumentMemAccessOutline(Value *Ptr, bool IsWrite, void HWAddressSanitizer::instrumentMemAccessOutline(Value *Ptr, bool IsWrite,
unsigned AccessSizeIndex, unsigned AccessSizeIndex,
Instruction *InsertBefore) { Instruction *InsertBefore) {
assert(!UsePageAliases); assert(!UsePageAliases);
const int64_t AccessInfo = getAccessInfo(IsWrite, AccessSizeIndex); const int64_t AccessInfo = getAccessInfo(IsWrite, AccessSizeIndex);
▲ Show 20 Lines • Show All 885 Lines • Show Last 20 Lines