This is an archive of the discontinued LLVM Phabricator instance.

[libc++] Implement constexpr {isfinite, isinf, isnan, isnormal}
ClosedPublic

Authored by philnik on Dec 18 2022, 3:10 PM.

Details

Summary

This starts implementing P0533

Diff Detail

Event Timeline

philnik created this revision.Dec 18 2022, 3:10 PM
Herald added a project: Restricted Project. · View Herald TranscriptDec 18 2022, 3:10 PM
philnik requested review of this revision.Dec 18 2022, 3:10 PM
Herald added a project: Restricted Project. · View Herald TranscriptDec 18 2022, 3:10 PM
Herald added a reviewer: Restricted Project. · View Herald Transcript
philnik updated this revision to Diff 483928.Dec 19 2022, 5:33 AM

Try to fix CI

Mordante accepted this revision.Dec 20 2022, 9:43 AM

LGTM modulo some nits.

libcxx/docs/Status/Cxx2b.rst
43

I really like this, this makes it easier to keep track regarding what is and what is not done. Thanks!

libcxx/test/std/numerics/c.math/isfinite.pass.cpp
9

Please add a synopsis, the same for the other tests.

20

Please test min and denorm_min too.

This revision is now accepted and ready to land.Dec 20 2022, 9:43 AM
philnik updated this revision to Diff 484853.Dec 22 2022, 8:41 AM
philnik marked 3 inline comments as done.
  • Address comments
  • Try to fix CI
philnik updated this revision to Diff 485229.Dec 25 2022, 7:30 AM

Try to fix CI

This revision was landed with ongoing or failed builds.Dec 25 2022, 11:14 AM
This revision was automatically updated to reflect the committed changes.