This is an archive of the discontinued LLVM Phabricator instance.

Differential D140105

[clang-format] add missing config parse test for short lambda
ClosedPublic

Authored by Backl1ght on Dec 15 2022, 7:04 AM.

Details

Reviewers
HazardyKnusperkeks
MyDeveloperDay
Commits
rG95c1a17433b9: [clang-format] add config parse test for short lambda
Summary

It looks like config parse test for short lambda is missing, and I think it should be added.

Diff Detail

Unit TestsFailed

TimeTest
11,480 mslibcxx CI C++2b > llvm-libc++-shared-cfg-in.libcxx/utilities/expected/expected_expected::assert.arrow.pass.cpp
11,460 mslibcxx CI C++2b > llvm-libc++-shared-cfg-in.libcxx/utilities/expected/expected_expected::assert.deref.pass.cpp
11,330 mslibcxx CI C++2b > llvm-libc++-shared-cfg-in.libcxx/utilities/expected/expected_expected::assert.error.pass.cpp
11,380 mslibcxx CI C++2b > llvm-libc++-shared-cfg-in.libcxx/utilities/expected/expected_void::assert.deref.pass.cpp
11,340 mslibcxx CI C++2b > llvm-libc++-shared-cfg-in.libcxx/utilities/expected/expected_void::assert.error.pass.cpp
View Full Test Results (124 Failed)

Event Timeline

Backl1ght created this revision.Dec 15 2022, 7:04 AM
Herald added a project: Restricted Project. · View Herald TranscriptDec 15 2022, 7:04 AM
Backl1ght requested review of this revision.Dec 15 2022, 7:04 AM
Herald added a project: Restricted Project. · View Herald TranscriptDec 15 2022, 7:04 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript
Backl1ght edited the summary of this revision. (Show Details)Dec 15 2022, 7:09 AM
Backl1ght added reviewers: HazardyKnusperkeks, MyDeveloperDay.
Harbormaster completed remote builds in B203346: Diff 483170.Dec 15 2022, 8:15 AM
HazardyKnusperkeks accepted this revision.Dec 15 2022, 11:01 AM
HazardyKnusperkeks added inline comments.
clang/unittests/Format/ConfigParseTest.cpp
545

Please add this comment.

This revision is now accepted and ready to land.Dec 15 2022, 11:01 AM
MyDeveloperDay accepted this revision.Dec 15 2022, 3:40 PM

LGTM

This revision was landed with ongoing or failed builds.Dec 16 2022, 5:37 AM
Closed by commit rG95c1a17433b9: [clang-format] add config parse test for short lambda (authored by Backl1ght). · Explain Why
This revision was automatically updated to reflect the committed changes.
Backl1ght added a commit: rG95c1a17433b9: [clang-format] add config parse test for short lambda.

Revision Contents

PathSize
clang/
unittests/
Format/
14 lines

Diff 483170

clang/unittests/Format/ConfigParseTest.cpp

Show First 20 Lines • Show All 527 Lines • ▼ Show 20 Lines#undef CHECK_ALIGN_CONSECUTIVE
CHECK_PARSE("AllowShortFunctionsOnASingleLine: All", CHECK_PARSE("AllowShortFunctionsOnASingleLine: All",
AllowShortFunctionsOnASingleLine, FormatStyle::SFS_All); AllowShortFunctionsOnASingleLine, FormatStyle::SFS_All);
// For backward compatibility: // For backward compatibility:
CHECK_PARSE("AllowShortFunctionsOnASingleLine: false", CHECK_PARSE("AllowShortFunctionsOnASingleLine: false",
AllowShortFunctionsOnASingleLine, FormatStyle::SFS_None); AllowShortFunctionsOnASingleLine, FormatStyle::SFS_None);
CHECK_PARSE("AllowShortFunctionsOnASingleLine: true", CHECK_PARSE("AllowShortFunctionsOnASingleLine: true",
AllowShortFunctionsOnASingleLine, FormatStyle::SFS_All); AllowShortFunctionsOnASingleLine, FormatStyle::SFS_All);
Style.AllowShortLambdasOnASingleLine = FormatStyle::SLS_All;
CHECK_PARSE("AllowShortLambdasOnASingleLine: None",
AllowShortLambdasOnASingleLine, FormatStyle::SLS_None);
CHECK_PARSE("AllowShortLambdasOnASingleLine: Empty",
AllowShortLambdasOnASingleLine, FormatStyle::SLS_Empty);
CHECK_PARSE("AllowShortLambdasOnASingleLine: Inline",
AllowShortLambdasOnASingleLine, FormatStyle::SLS_Inline);
CHECK_PARSE("AllowShortLambdasOnASingleLine: All",
AllowShortLambdasOnASingleLine, FormatStyle::SLS_All);
CHECK_PARSE("AllowShortLambdasOnASingleLine: false",
HazardyKnusperkeksUnsubmitted
Not Done
ReplyInline Actions
AllowShortLambdasOnASingleLine, FormatStyle::SLS_All);
- CHECK_PARSE("AllowShortLambdasOnASingleLine: false",
+ // For backward compatibility:
+ CHECK_PARSE("AllowShortLambdasOnASingleLine: false",
AllowShortLambdasOnASingleLine, FormatStyle::SLS_None);

Please add this comment.

HazardyKnusperkeks: Please add this comment.
AllowShortLambdasOnASingleLine, FormatStyle::SLS_None);
CHECK_PARSE("AllowShortLambdasOnASingleLine: true",
AllowShortLambdasOnASingleLine, FormatStyle::SLS_All);
Style.SpaceAroundPointerQualifiers = FormatStyle::SAPQ_Both; Style.SpaceAroundPointerQualifiers = FormatStyle::SAPQ_Both;
CHECK_PARSE("SpaceAroundPointerQualifiers: Default", CHECK_PARSE("SpaceAroundPointerQualifiers: Default",
SpaceAroundPointerQualifiers, FormatStyle::SAPQ_Default); SpaceAroundPointerQualifiers, FormatStyle::SAPQ_Default);
CHECK_PARSE("SpaceAroundPointerQualifiers: Before", CHECK_PARSE("SpaceAroundPointerQualifiers: Before",
SpaceAroundPointerQualifiers, FormatStyle::SAPQ_Before); SpaceAroundPointerQualifiers, FormatStyle::SAPQ_Before);
CHECK_PARSE("SpaceAroundPointerQualifiers: After", CHECK_PARSE("SpaceAroundPointerQualifiers: After",
SpaceAroundPointerQualifiers, FormatStyle::SAPQ_After); SpaceAroundPointerQualifiers, FormatStyle::SAPQ_After);
CHECK_PARSE("SpaceAroundPointerQualifiers: Both", CHECK_PARSE("SpaceAroundPointerQualifiers: Both",
▲ Show 20 Lines • Show All 735 Lines • Show Last 20 Lines