This is an archive of the discontinued LLVM Phabricator instance.

Differential D140050

[draft][libc++] Add CI job testing on FreeBSD
AbandonedPublic

Authored by emaste on Dec 14 2022, 1:05 PM.

Details

Reviewers
None
Summary

D128084 for testing

Diff Detail

Unit TestsFailed

TimeTest
13,930 mslibcxx CI Clang-cl (no vcruntime exceptions) > llvm-libc++-shared-no-vcruntime-clangcl-cfg-in.std/thread/thread_mutex/thread_lock/thread_lock_shared/thread_lock_shared_cons::mutex_try_to_lock.pass.cpp

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes
emaste mentioned this in D128084: [libc++] Add CI job testing on FreeBSD.Dec 14 2022, 3:08 PM
Harbormaster completed remote builds in B203204: Diff 482974.Dec 14 2022, 3:43 PM
emaste updated this revision to Diff 483020.Dec 14 2022, 3:59 PM

rebase

emaste updated this revision to Diff 483023.Dec 14 2022, 4:04 PM

For testing, move the FreeBSD job to the top

Harbormaster completed remote builds in B203235: Diff 483023.Dec 14 2022, 4:19 PM
emaste updated this revision to Diff 483031.Dec 14 2022, 4:39 PM

rebase

Harbormaster completed remote builds in B203239: Diff 483031.Dec 14 2022, 4:47 PM
emaste updated this revision to Diff 483035.Dec 14 2022, 4:49 PM

rebase

Harbormaster completed remote builds in B203243: Diff 483035.Dec 14 2022, 5:07 PM
emaste updated this revision to Diff 483164.Dec 15 2022, 6:38 AM

restore XFAILs from D128084 that had merge conflicts

Harbormaster completed remote builds in B203341: Diff 483164.Dec 15 2022, 8:40 AM
emaste updated this revision to Diff 483231.Dec 15 2022, 10:28 AM

Incorporate D140117

Harbormaster completed remote builds in B203385: Diff 483231.Dec 15 2022, 11:31 AM
emaste updated this revision to Diff 483292.Dec 15 2022, 12:11 PM

rebase

Harbormaster completed remote builds in B203436: Diff 483292.Dec 15 2022, 12:36 PM
emaste updated this revision to Diff 483314.Dec 15 2022, 1:06 PM

rebase

Harbormaster completed remote builds in B203452: Diff 483314.Dec 15 2022, 2:27 PM
emaste updated this revision to Diff 483506.Dec 16 2022, 5:43 AM

rebase

Harbormaster completed remote builds in B203591: Diff 483506.Dec 16 2022, 6:52 AM
emaste updated this revision to Diff 483529.Dec 16 2022, 7:00 AM

use clang15 explicitly for FreeBSD

Harbormaster completed remote builds in B203610: Diff 483529.Dec 16 2022, 7:35 AM
emaste updated this revision to Diff 483556.Dec 16 2022, 8:41 AM

rebase

Harbormaster completed remote builds in B203630: Diff 483556.Dec 16 2022, 9:20 AM
emaste updated this revision to Diff 483588.Dec 16 2022, 10:30 AM

add xfails

Harbormaster completed remote builds in B203655: Diff 483588.Dec 16 2022, 11:09 AM
emaste updated this revision to Diff 483619.Dec 16 2022, 11:37 AM

remove xfail from now passing tests

Harbormaster completed remote builds in B203682: Diff 483619.Dec 16 2022, 12:17 PM
emaste updated this revision to Diff 483644.Dec 16 2022, 12:56 PM

hack out check-cxx-abilist for now

Harbormaster completed remote builds in B203700: Diff 483644.Dec 16 2022, 1:36 PM
emaste updated this revision to Diff 483665.Dec 16 2022, 1:54 PM

remove check-cxx-abilist for testing

Harbormaster completed remote builds in B203715: Diff 483665.Dec 16 2022, 2:40 PM
emaste updated this revision to Diff 483687.Dec 16 2022, 4:02 PM

rebase

Harbormaster completed remote builds in B203729: Diff 483687.Dec 16 2022, 4:42 PM
emaste updated this revision to Diff 483754.Dec 17 2022, 8:56 AM

rebase

Harbormaster completed remote builds in B203763: Diff 483754.Dec 17 2022, 10:06 AM
emaste updated this revision to Diff 484252.Dec 20 2022, 6:44 AM

rebase

Harbormaster completed remote builds in B204149: Diff 484252.Dec 20 2022, 7:25 AM
emaste updated this revision to Diff 484351.Dec 20 2022, 1:02 PM

remove xfails for now passing tests

Harbormaster completed remote builds in B204226: Diff 484351.Dec 20 2022, 1:48 PM
emaste updated this revision to Diff 484375.Dec 20 2022, 2:02 PM

Adjust xfails

Harbormaster completed remote builds in B204237: Diff 484375.Dec 20 2022, 2:41 PM
emaste updated this revision to Diff 484408.Dec 20 2022, 3:40 PM

rebase

Harbormaster completed remote builds in B204266: Diff 484408.Dec 20 2022, 4:32 PM
emaste updated this revision to Diff 484565.Dec 21 2022, 6:38 AM

Temporarily remove two tests that are inconsistent on FreeBSD. These tests time out or fail on occasion, so temporarily remove them to continue making progress with other work.

  • libcxx/test/std/atomics/atomics.types.operations/atomics.types.operations.wait/atomic_wait.pass.cpp
  • libcxx/test/std/atomics/atomics.types.operations/atomics.types.operations.wait/atomic_wait_explicit.pass.cpp
Harbormaster completed remote builds in B204380: Diff 484565.Dec 21 2022, 7:20 AM
emaste updated this revision to Diff 484603.Dec 21 2022, 9:30 AM

Rebase after ABI list committed to repo

Harbormaster completed remote builds in B204404: Diff 484603.Dec 21 2022, 10:12 AM
emaste updated this revision to Diff 484629.Dec 21 2022, 11:12 AM

skip another failing test

Harbormaster completed remote builds in B204421: Diff 484629.Dec 21 2022, 11:54 AM
emaste updated this revision to Diff 484666.Dec 21 2022, 1:47 PM

add nonew abi list

Harbormaster completed remote builds in B204447: Diff 484666.Dec 21 2022, 2:29 PM
emaste updated this revision to Diff 484806.Dec 22 2022, 5:38 AM

rename abilist

Harbormaster completed remote builds in B204559: Diff 484806.Dec 22 2022, 6:19 AM
emaste updated this revision to Diff 484902.Dec 22 2022, 11:12 AM

rename abilist file

Harbormaster completed remote builds in B204626: Diff 484902.Dec 22 2022, 1:48 PM
emaste updated this revision to Diff 486965.Jan 6 2023, 12:52 PM

rebase

Harbormaster completed remote builds in B206183: Diff 486965.Jan 6 2023, 1:03 PM
emaste updated this revision to Diff 486971.Jan 6 2023, 1:07 PM

revert part of 841399a2188aaf244e83e3df7be66885ec905ede for testing

Harbormaster completed remote builds in B206185: Diff 486971.Jan 6 2023, 1:48 PM
emaste updated this revision to Diff 486984.Jan 6 2023, 1:57 PM

add xfails to time tests that started failing (again?)

Herald added a subscriber: arphaman. · View Herald TranscriptJan 6 2023, 1:57 PM
Harbormaster completed remote builds in B206197: Diff 486984.Jan 6 2023, 2:38 PM
emaste updated this revision to Diff 487792.Jan 10 2023, 6:51 AM

rebase, tweak symbol list

Harbormaster completed remote builds in B206786: Diff 487792.Jan 10 2023, 7:34 AM
emaste updated this revision to Diff 487805.Jan 10 2023, 7:49 AM

fix python

Harbormaster completed remote builds in B206796: Diff 487805.Jan 10 2023, 8:31 AM
emaste updated this revision to Diff 487884.Jan 10 2023, 10:41 AM

Rebase, update symbols

emaste updated this revision to Diff 487916.Jan 10 2023, 11:50 AM

rebase and tweak symbols again

emaste updated this revision to Diff 487958.Jan 10 2023, 12:58 PM

tweak symbols again, rebase

Harbormaster completed remote builds in B206906: Diff 487958.Jan 10 2023, 7:14 PM
emaste updated this revision to Diff 488206.Jan 11 2023, 7:19 AM

rebase after ABI list change put in D141496

Harbormaster completed remote builds in B207083: Diff 488206.Jan 11 2023, 9:16 AM
emaste updated this revision to Diff 488295.Jan 11 2023, 11:09 AM

sorting & curating patches

emaste updated this revision to Diff 488370.Jan 11 2023, 1:43 PM

rebase

Harbormaster completed remote builds in B207207: Diff 488370.Jan 11 2023, 1:47 PM
emaste updated this revision to Diff 488376.Jan 11 2023, 1:56 PM

fixup pipeline

emaste updated this revision to Diff 488448.Jan 11 2023, 6:10 PM

rebase

Harbormaster completed remote builds in B207260: Diff 488448.Jan 11 2023, 8:54 PM
emaste updated this revision to Diff 488700.Jan 12 2023, 9:43 AM

rebase, skip all non-FreeBSD for testing

Herald added a subscriber: mstorsjo. · View Herald TranscriptJan 12 2023, 9:43 AM
Harbormaster completed remote builds in B207437: Diff 488700.Jan 12 2023, 10:28 AM
emaste updated this revision to Diff 488732.Jan 12 2023, 12:02 PM

test without _LIBCPP_DEPRECATED_ABI_DISABLE_PAIR_TRIVIAL_COPY_CTOR change

Harbormaster completed remote builds in B207457: Diff 488732.Jan 12 2023, 12:45 PM
emaste updated this revision to Diff 488767.Jan 12 2023, 1:53 PM

retest flakey tests

Harbormaster completed remote builds in B207479: Diff 488767.Jan 12 2023, 1:57 PM
emaste updated this revision to Diff 488814.Jan 12 2023, 5:07 PM

use // ADDITIONAL_COMPILE_FLAGS: -Wno-macro-redefined

Harbormaster completed remote builds in B207514: Diff 488814.Jan 12 2023, 5:57 PM
emaste updated this revision to Diff 489310.Jan 14 2023, 1:05 PM

rebase

Harbormaster completed remote builds in B207872: Diff 489310.Jan 14 2023, 1:58 PM
emaste updated this revision to Diff 489523.Jan 16 2023, 5:52 AM

rebase

Harbormaster completed remote builds in B208031: Diff 489523.Jan 16 2023, 7:14 AM
emaste updated this revision to Diff 489568.Jan 16 2023, 8:22 AM

rebase, remove a test that timed out on FreeBSD

Harbormaster completed remote builds in B208064: Diff 489568.Jan 16 2023, 9:09 AM
emaste updated this revision to Diff 489619.Jan 16 2023, 11:57 AM

rebase, restore clang-tidy

Harbormaster completed remote builds in B208098: Diff 489619.Jan 16 2023, 1:25 PM
emaste updated this revision to Diff 489996.Jan 17 2023, 5:20 PM

rebase, add tests back, add kib's atomic patch

Harbormaster completed remote builds in B208375: Diff 489996.Jan 17 2023, 6:19 PM
emaste updated this revision to Diff 490012.Jan 17 2023, 6:24 PM

no hard tabs

Harbormaster completed remote builds in B208389: Diff 490012.Jan 17 2023, 7:21 PM
emaste updated this revision to Diff 490550.Jan 19 2023, 9:05 AM

rebase

Harbormaster completed remote builds in B208780: Diff 490550.Jan 19 2023, 9:52 AM
emaste updated this revision to Diff 490881.Jan 20 2023, 8:44 AM

rebase after D141294

Harbormaster completed remote builds in B209009: Diff 490881.Jan 20 2023, 10:24 AM
emaste updated this revision to Diff 490973.Jan 20 2023, 1:52 PM

update to final candidate version

Harbormaster completed remote builds in B209070: Diff 490973.Jan 20 2023, 3:58 PM
emaste updated this revision to Diff 491010.Jan 20 2023, 5:20 PM

rebase, apply https://reviews.freebsd.org/D38132

Harbormaster completed remote builds in B209100: Diff 491010.Jan 20 2023, 6:12 PM
emaste updated this revision to Diff 491187.Jan 22 2023, 10:19 AM

rebase

Harbormaster completed remote builds in B209242: Diff 491187.Jan 22 2023, 1:11 PM
emaste updated this revision to Diff 491368.Jan 23 2023, 7:24 AM

rebase

Harbormaster completed remote builds in B209373: Diff 491368.Jan 23 2023, 9:35 AM
emaste updated this revision to Diff 501637.Mar 1 2023, 12:45 PM

rebase

Harbormaster completed remote builds in B216815: Diff 501637.Mar 1 2023, 2:00 PM
emaste updated this revision to Diff 501664.Mar 1 2023, 2:13 PM

adjust xfails

Harbormaster completed remote builds in B216836: Diff 501664.Mar 1 2023, 4:15 PM
emaste updated this revision to Diff 501694.Mar 1 2023, 4:18 PM

regen

Harbormaster completed remote builds in B216857: Diff 501694.Mar 1 2023, 5:49 PM
emaste updated this revision to Diff 501726.Mar 1 2023, 6:23 PM

regen

Harbormaster completed remote builds in B216885: Diff 501726.Mar 1 2023, 6:50 PM
emaste updated this revision to Diff 501837.Mar 2 2023, 5:36 AM

rebase

Harbormaster completed remote builds in B216953: Diff 501837.Mar 2 2023, 6:02 AM
emaste updated this revision to Diff 501844.Mar 2 2023, 6:05 AM

remove C++2b and Modular build, which are failing apparently unrelated to my work

Harbormaster completed remote builds in B216960: Diff 501844.Mar 2 2023, 7:30 AM
emaste updated this revision to Diff 501878.Mar 2 2023, 8:15 AM

rebase

Harbormaster completed remote builds in B216986: Diff 501878.Mar 2 2023, 9:13 AM
emaste updated this revision to Diff 501897.Mar 2 2023, 9:38 AM

try reverting umtx changes

Harbormaster completed remote builds in B216996: Diff 501897.Mar 2 2023, 10:33 AM
emaste updated this revision to Diff 502736.Mar 6 2023, 11:09 AM

regen

Harbormaster completed remote builds in B217653: Diff 502736.Mar 6 2023, 3:06 PM
emaste abandoned this revision.Mar 9 2023, 11:15 AM

This review was just used for triggering and testing FreeBSD CI; actual change committed via D128084.

Revision Contents

PathSize
libcxx/
test/
libcxx/
2 lines
utils/
ci/
55 lines

Diff 502736

libcxx/test/libcxx/modules_include.sh.cpp

Context not available.
// The system-provided <uchar.h> seems to be broken on AIX // The system-provided <uchar.h> seems to be broken on AIX
// XFAIL: LIBCXX-AIX-FIXME // XFAIL: LIBCXX-AIX-FIXME
// XFAIL: LIBCXX-FREEBSD-FIXME
// GCC doesn't support -fcxx-modules // GCC doesn't support -fcxx-modules
// UNSUPPORTED: gcc // UNSUPPORTED: gcc
Context not available.

libcxx/utils/ci/buildkite-pipeline.yml

Context not available.
limit: 2 limit: 2
timeout_in_minutes: 120 timeout_in_minutes: 120
- label: "C++2b"
command: "libcxx/utils/ci/run-buildbot generic-cxx2b"
artifact_paths:
- "**/test-results.xml"
- "**/*.abilist"
env:
CC: "clang-${LLVM_HEAD_VERSION}"
CXX: "clang++-${LLVM_HEAD_VERSION}"
ENABLE_CLANG_TIDY: "On"
agents:
queue: "libcxx-builders"
os: "linux"
retry:
automatic:
- exit_status: -1 # Agent was lost
limit: 2
timeout_in_minutes: 120
- label: "Modular build"
command: "libcxx/utils/ci/run-buildbot generic-modules"
artifact_paths:
- "**/test-results.xml"
- "**/*.abilist"
env:
CC: "clang-${LLVM_HEAD_VERSION}"
CXX: "clang++-${LLVM_HEAD_VERSION}"
ENABLE_CLANG_TIDY: "On"
agents:
queue: "libcxx-builders"
os: "linux"
retry:
automatic:
- exit_status: -1 # Agent was lost
limit: 2
timeout_in_minutes: 120
- label: "C++11" - label: "C++11"
command: "libcxx/utils/ci/run-buildbot generic-cxx11" command: "libcxx/utils/ci/run-buildbot generic-cxx11"
artifact_paths: artifact_paths:
Context not available.
- exit_status: -1 # Agent was lost - exit_status: -1 # Agent was lost
limit: 2 limit: 2
timeout_in_minutes: 120 timeout_in_minutes: 120
- group: "FreeBSD"
steps:
- label: "FreeBSD 13 amd64"
command: "libcxx/utils/ci/run-buildbot generic-cxx2b"
artifact_paths:
- "**/test-results.xml"
- "**/*.abilist"
env:
CC: "clang15"
CXX: "clang++15"
agents:
queue: "libcxx-builders"
os: "freebsd"
retry:
automatic:
- exit_status: -1 # Agent was lost
limit: 2
timeout_in_minutes: 120
Context not available.