Differential D139889

[Clang] Fix a crash when encountering an ill-formed delimited UCN.
ClosedPublic
Actions

Authored by cor3ntin on Dec 12 2022, 3:28 PM.

Details

Reviewers

tahonermann

Commits

rG0d6b26b4d3e3: [Clang] Fix a crash when encountering an ill-formed delimited UCN.

Summary

\u<DIGIT>{...} was incorrectly parsed as a valid UCN instead
of emitting a diagnostic, causing an assertion failure.

Diff Detail

Repository: rG LLVM Github Monorepo

Event Timeline

cor3ntin created this revision.Dec 12 2022, 3:28 PM

Herald added a project: Restricted Project. · View Herald TranscriptDec 12 2022, 3:28 PM

cor3ntin requested review of this revision.Dec 12 2022, 3:28 PM

Herald added a project: Restricted Project. · View Herald TranscriptDec 12 2022, 3:28 PM

Herald added a subscriber: cfe-commits. · View Herald Transcript

cor3ntin added a reviewer: tahonermann.Dec 12 2022, 3:29 PM

cor3ntin mentioned this in D138861: [Clang] Implement CWG2640 Allow more characters in an n-char sequence.

Harbormaster completed remote builds in B202707: Diff 482294.Dec 12 2022, 4:21 PM

@tahonermann gentle ping :)

Looks good! Sorry, Corentin, this review had fallen off my radar!

This revision is now accepted and ready to land.Jan 3 2023, 8:35 AM

Closed by commit rG0d6b26b4d3e3: [Clang] Fix a crash when encountering an ill-formed delimited UCN. (authored by cor3ntin). · Explain WhyJan 3 2023, 11:58 AM

This revision was automatically updated to reflect the committed changes.

cor3ntin added a commit: rG0d6b26b4d3e3: [Clang] Fix a crash when encountering an ill-formed delimited UCN..

@tahonermann Thanks :)

Revision Contents
Changeset List

Path

Size

clang/

lib/

Lex/

Lexer.cpp

2 lines

test/

Preprocessor/

ucn-pp-identifier.c

1 line

Diff 486045

View Options

clang/lib/Lex/Lexer.cpp

View Options

clang/test/Preprocessor/ucn-pp-identifier.c

Please use GitHub pull requests for new patches. Phabricator shutdown timeline

[Clang] Fix a crash when encountering an ill-formed delimited UCN.ClosedPublicActions