This is an archive of the discontinued LLVM Phabricator instance.

[Clang] Fix a crash when encountering an ill-formed delimited UCN.
ClosedPublic

Authored by cor3ntin on Dec 12 2022, 3:28 PM.

Details

Summary

\u<DIGIT>{...} was incorrectly parsed as a valid UCN instead
of emitting a diagnostic, causing an assertion failure.

Diff Detail

Event Timeline

cor3ntin created this revision.Dec 12 2022, 3:28 PM
Herald added a project: Restricted Project. · View Herald TranscriptDec 12 2022, 3:28 PM
cor3ntin requested review of this revision.Dec 12 2022, 3:28 PM
Herald added a project: Restricted Project. · View Herald TranscriptDec 12 2022, 3:28 PM
Herald added a subscriber: cfe-commits. · View Herald Transcript
tahonermann accepted this revision.Jan 3 2023, 8:35 AM

Looks good! Sorry, Corentin, this review had fallen off my radar!

This revision is now accepted and ready to land.Jan 3 2023, 8:35 AM