This is an archive of the discontinued LLVM Phabricator instance.

Differential D139463

Fix breakpoint-command.test when no script interpreter is compiled in.
ClosedPublic

Authored by hctim on Dec 6 2022, 2:26 PM.

Details

Reviewers
JDevlieghere
labath
Commits
rG1b753240d50a: Fix breakpoint-command.test when no script interpreter is compiled in.
Summary

My local build is with -DLLVM_ENABLE_PROJECTS=lldb, but I don't compile
with -DLLDB_ENABLE_PYTHON=True or -DLLDB_ENABLE_LUA=True. This results
in there being no script interpreter.

The test lldb/test/Shell/Breakpoint/breakpoint-command.test has an
implicit dependency on a script interpreter being available.

This patch makes that dependency clear. If you have a script
interpreter, the test gets run, otherwise it gets skipped. This means
that folks (like me) who naively use -DLLVM_ENABLE_PROJECTS=lldb can
continue to run check-all without breakages.

Diff Detail

Event Timeline

hctim created this revision.Dec 6 2022, 2:26 PM
Herald added a project: Restricted Project. · View Herald TranscriptDec 6 2022, 2:26 PM
hctim requested review of this revision.Dec 6 2022, 2:26 PM
Herald added a project: Restricted Project. · View Herald TranscriptDec 6 2022, 2:26 PM
Herald added a subscriber: lldb-commits. · View Herald Transcript
Harbormaster completed remote builds in B201491: Diff 480623.Dec 6 2022, 2:29 PM
labath added inline comments.Dec 12 2022, 4:37 AM
lldb/test/Shell/Breakpoint/breakpoint-command.test
2

Maybe this could just be REQUIRES: lua || python? I don't expect we will have many tests that depend on the existence of a generic script interpreter (in fact, it's kinda amazing that this bilingual expression even works).

hctim marked an inline comment as done.Dec 12 2022, 10:52 AM
hctim added inline comments.
lldb/test/Shell/Breakpoint/breakpoint-command.test
2

yeah, let's go with that

hctim updated this revision to Diff 482190.Dec 12 2022, 10:53 AM
hctim marked an inline comment as done.

change to using existing python/lua glue

Harbormaster completed remote builds in B202628: Diff 482190.Dec 12 2022, 10:56 AM
JDevlieghere accepted this revision.Dec 12 2022, 11:05 AM

LGTM. Thanks!

This revision is now accepted and ready to land.Dec 12 2022, 11:05 AM
Closed by commit rG1b753240d50a: Fix breakpoint-command.test when no script interpreter is compiled in. (authored by hctim). · Explain WhyDec 12 2022, 2:13 PM
This revision was automatically updated to reflect the committed changes.
hctim added a commit: rG1b753240d50a: Fix breakpoint-command.test when no script interpreter is compiled in..

Revision Contents

PathSize
lldb/
test/
Shell/
Breakpoint/
2 lines

Diff 482264

lldb/test/Shell/Breakpoint/breakpoint-command.test

# REQUIRES: lua || python
labathUnsubmitted
Done
ReplyInline Actions

Maybe this could just be REQUIRES: lua || python? I don't expect we will have many tests that depend on the existence of a generic script interpreter (in fact, it's kinda amazing that this bilingual expression even works).

labath: Maybe this could just be `REQUIRES: lua || python`? I don't expect we will have many tests that…
hctimAuthorUnsubmitted
Done
ReplyInline Actions

yeah, let's go with that

hctim: yeah, let's go with that
# RUN: %build %p/Inputs/dummy-target.c -o %t.out # RUN: %build %p/Inputs/dummy-target.c -o %t.out
# RUN: %lldb %t.out -o 'b main' -o 'break command add 1 -o "script print(95000 + 126)"' -o 'r' | FileCheck %s # RUN: %lldb %t.out -o 'b main' -o 'break command add 1 -o "script print(95000 + 126)"' -o 'r' | FileCheck %s
# CHECK: 95126 # CHECK: 95126
# CHECK-NOT: 95126 # CHECK-NOT: 95126