This is an archive of the discontinued LLVM Phabricator instance.

Differential D139461

Fix dwarf5-lazy-dwo.c for the default c target not being c99.
ClosedPublic

Authored by hctim on Dec 6 2022, 2:15 PM.

Details

Reviewers
Eric
jankratochvil
herhut
Commits
rGfc5bda52f00b: Fix dwarf5-lazy-dwo.c for the default c target not being c99.
Summary

My host compiler is clang version 15.0.0, which uses -std=c11 by
default. The test asserts that the language is 'c99', and so the test
fails locally.

Update the test to be explicit about compiling with 'c99'.

Diff Detail

Event Timeline

hctim created this revision.Dec 6 2022, 2:15 PM
Herald added a project: Restricted Project. · View Herald TranscriptDec 6 2022, 2:15 PM
hctim requested review of this revision.Dec 6 2022, 2:15 PM
Herald added a project: Restricted Project. · View Herald TranscriptDec 6 2022, 2:15 PM
Herald added a subscriber: lldb-commits. · View Herald Transcript
Harbormaster completed remote builds in B201487: Diff 480618.Dec 6 2022, 2:16 PM
Herald added a subscriber: JDevlieghere. · View Herald TranscriptDec 6 2022, 2:16 PM
Eric accepted this revision.Dec 7 2022, 4:23 AM

LGTM. It would also be fine to not check the language.

This revision is now accepted and ready to land.Dec 7 2022, 4:23 AM
This revision was landed with ongoing or failed builds.Dec 7 2022, 9:08 AM
Closed by commit rGfc5bda52f00b: Fix dwarf5-lazy-dwo.c for the default c target not being c99. (authored by hctim). · Explain Why
This revision was automatically updated to reflect the committed changes.
hctim added a commit: rGfc5bda52f00b: Fix dwarf5-lazy-dwo.c for the default c target not being c99..

Revision Contents

PathSize
lldb/
test/
Shell/
SymbolFile/
DWARF/
6 lines

Diff 480945

lldb/test/Shell/SymbolFile/DWARF/dwarf5-lazy-dwo.c

// Test we load dwo information lazily. // Test we load dwo information lazily.
// -gsplit-dwarf is supported only on Linux. // -gsplit-dwarf is supported only on Linux.
// REQUIRES: system-linux // REQUIRES: system-linux
// RUN: %clang_host %s -fno-standalone-debug -g \ // RUN: %clang_host %s -fno-standalone-debug -g -std=c99 \
// RUN: -gdwarf-5 -gpubnames -gsplit-dwarf -c -o %t1.o -DONE // RUN: -gdwarf-5 -gpubnames -gsplit-dwarf -c -o %t1.o -DONE
// RUN: %clang_host %s -fno-standalone-debug -g \ // RUN: %clang_host %s -fno-standalone-debug -g -std=c99 \
// RUN: -gdwarf-5 -gpubnames -gsplit-dwarf -c -o %t2.o -DTWO // RUN: -gdwarf-5 -gpubnames -gsplit-dwarf -c -o %t2.o -DTWO
// RUN: %clang_host %t1.o %t2.o -o %t // RUN: %clang_host %t1.o %t2.o -o %t -std=c99
// RUN: %lldb %t -o "log enable 'lldb' object" -o "settings set stop-line-count-before 0" \ // RUN: %lldb %t -o "log enable 'lldb' object" -o "settings set stop-line-count-before 0" \
// RUN: -o "b main" -o "run" -o "image lookup -n main -v" -b | FileCheck %s // RUN: -o "b main" -o "run" -o "image lookup -n main -v" -b | FileCheck %s
// CHECK-NOT: 2.dwo, // CHECK-NOT: 2.dwo,
// CHECK: (lldb) b main // CHECK: (lldb) b main
// CHECK-NOT: 2.dwo, // CHECK-NOT: 2.dwo,
// CHECK: 1.dwo, // CHECK: 1.dwo,
// CHECK-NOT: 2.dwo, // CHECK-NOT: 2.dwo,
Show All 15 Lines