This is an archive of the discontinued LLVM Phabricator instance.

Differential D139361

[lldb-tests] Force system's libcxx on tests failing with debug symbols
ClosedPublic

Authored by fdeazeve on Dec 5 2022, 12:57 PM.

Details

Reviewers
JDevlieghere
Michael137
jasonmolenda
jingham
Commits
rGb1fcc1840c31: [lldb-tests] Force system's libcxx on tests failing with debug symbols
Summary

The tests in this patch expose failures of LLDBs expression evaluator
when a standard library is compiled with debug symbols. This is the case
for RelWithDebugInfo builds of llvm-project (with libcxx).

Until these bugs are fixed, we force these tests to use the system's
standard library.

Diff Detail

Event Timeline

fdeazeve created this revision.Dec 5 2022, 12:57 PM
Herald added a project: Restricted Project. · View Herald TranscriptDec 5 2022, 12:57 PM
fdeazeve requested review of this revision.Dec 5 2022, 12:57 PM
Herald added a project: Restricted Project. · View Herald TranscriptDec 5 2022, 12:57 PM
Herald added a subscriber: lldb-commits. · View Herald Transcript
fdeazeve added reviewers: JDevlieghere, Michael137, jasonmolenda, jingham.Dec 5 2022, 12:58 PM
Harbormaster completed remote builds in B201195: Diff 480212.Dec 5 2022, 1:00 PM
fdeazeve updated this revision to Diff 480214.Dec 5 2022, 1:01 PM

Add FIXME comment with the same observation from the commit message.

Harbormaster completed remote builds in B201197: Diff 480214.Dec 5 2022, 1:05 PM
Michael137 accepted this revision.Dec 5 2022, 1:11 PM
This revision is now accepted and ready to land.Dec 5 2022, 1:11 PM
JDevlieghere accepted this revision.Dec 5 2022, 1:27 PM

Thanks!

Closed by commit rGb1fcc1840c31: [lldb-tests] Force system's libcxx on tests failing with debug symbols (authored by fdeazeve). · Explain WhyDec 5 2022, 2:42 PM
This revision was automatically updated to reflect the committed changes.
fdeazeve added a commit: rGb1fcc1840c31: [lldb-tests] Force system's libcxx on tests failing with debug symbols.
Michael137 mentioned this in D156827: [lldb][test] Skip *-dbg-info-content API tests.Aug 1 2023, 2:19 PM
Michael137 mentioned this in rG5ce7831b4023: [lldb][test] Skip *-dbg-info-content API tests.Aug 1 2023, 2:43 PM

Revision Contents

PathSize
lldb/
test/
API/
commands/
expression/
import-std-module/
deque-dbg-info-content/
4 lines
list-dbg-info-content/
4 lines
vector-dbg-info-content/
4 lines

Diff 480254

lldb/test/API/commands/expression/import-std-module/deque-dbg-info-content/Makefile

USE_LIBCPP := 1 # FIXME: once the expression evaluator can handle std libraries with debug
# info, change this to USE_LIBCPP=1
USE_SYSTEM_STDLIB := 1
CXX_SOURCES := main.cpp CXX_SOURCES := main.cpp
include Makefile.rules include Makefile.rules

lldb/test/API/commands/expression/import-std-module/list-dbg-info-content/Makefile

USE_LIBCPP := 1 # FIXME: once the expression evaluator can handle std libraries with debug
# info, change this to USE_LIBCPP=1
USE_SYSTEM_STDLIB := 1
CXX_SOURCES := main.cpp CXX_SOURCES := main.cpp
include Makefile.rules include Makefile.rules

lldb/test/API/commands/expression/import-std-module/vector-dbg-info-content/Makefile

USE_LIBCPP := 1 # FIXME: once the expression evaluator can handle std libraries with debug
# info, change this to USE_LIBCPP=1
USE_SYSTEM_STDLIB := 1
CXX_SOURCES := main.cpp CXX_SOURCES := main.cpp
include Makefile.rules include Makefile.rules