This is an archive of the discontinued LLVM Phabricator instance.

Paths

Table of Contentst

-
compiler-rt/cmake/Modules/
-
cmake/
-
Modules/
-
AllSupportedArchDefs.cmake

Differential D139292

[ubsan] Enable loongarch64
ClosedPublic

Authored by tangyouling on Dec 4 2022, 10:16 PM.

Download Raw Diff

Details

Reviewers

SixWeining
xen0n
xry111
MaskRay
XiaodongLoong

Group Reviewers

Restricted Project

Commits

rGd3174549d25e: [ubsan] Enable loongarch64

Summary

Enable ubsan on LoongArch64.

Diff Detail

Repository: rG LLVM Github Monorepo

Event Timeline

tangyouling created this revision.Dec 4 2022, 10:16 PM

Herald added a project: Restricted Project. · View Herald TranscriptDec 4 2022, 10:16 PM

Herald added subscribers: Enna1, StephenFan, fedor.sergeev. · View Herald Transcript

tangyouling requested review of this revision.Dec 4 2022, 10:16 PM

Herald added a project: Restricted Project. · View Herald TranscriptDec 4 2022, 10:16 PM

Herald added a subscriber: Restricted Project. · View Herald Transcript

tangyouling added a reviewer: Restricted Project.Dec 4 2022, 10:17 PM

This really doesn't need porting? Am I overlooking something?

In D139292#3969867, @xen0n wrote:

This really doesn't need porting? Am I overlooking something?

The test results after enabling ubsan and applying the tsan support patch are as follows,

$ make check-ubsan -j4
Testing Time: 146.26s
  Unsupported      :  23
  Passed           : 228
  Expectedly Failed:   1

6 warning(s) in tests
Built target check-ubsan

ubsan runtime almost has no arch-specific customization, so enabling it for build suffices. I don't have an environment to test it myself, though...

This revision is now accepted and ready to land.Dec 4 2022, 10:36 PM

[ubsan] Enable for loongarch64

Enable loongarch64

In D139292#3969902, @MaskRay wrote:

[ubsan] Enable for loongarch64

Enable loongarch64

Fair enough.

In D139292#3969899, @MaskRay wrote:

ubsan runtime almost has no arch-specific customization, so enabling it for build suffices. I don't have an environment to test it myself, though...

Oh that's good to know... fine by me then.

Harbormaster completed remote builds in B201022: Diff 479983.Dec 4 2022, 11:00 PM

SixWeining accepted this revision.Dec 4 2022, 11:32 PM

Closed by commit rGd3174549d25e: [ubsan] Enable loongarch64 (authored by tangyouling, committed by SixWeining). · Explain WhyDec 7 2022, 6:14 PM

This revision was automatically updated to reflect the committed changes.

SixWeining added a commit: rGd3174549d25e: [ubsan] Enable loongarch64.

Revision Contents

Path

Size

compiler-rt/

cmake/

Modules/

AllSupportedArchDefs.cmake

3 lines

Diff 481134

compiler-rt/cmake/Modules/AllSupportedArchDefs.cmake

	Show First 20 Lines • Show All 57 Lines • ▼ Show 20 Lines
	set(ALL_HWASAN_SUPPORTED_ARCH ${X86_64} ${ARM64})			set(ALL_HWASAN_SUPPORTED_ARCH ${X86_64} ${ARM64})
	set(ALL_MEMPROF_SUPPORTED_ARCH ${X86_64})			set(ALL_MEMPROF_SUPPORTED_ARCH ${X86_64})
	set(ALL_PROFILE_SUPPORTED_ARCH ${X86} ${X86_64} ${ARM32} ${ARM64} ${PPC32} ${PPC64}			set(ALL_PROFILE_SUPPORTED_ARCH ${X86} ${X86_64} ${ARM32} ${ARM64} ${PPC32} ${PPC64}
	${MIPS32} ${MIPS64} ${S390X} ${SPARC} ${SPARCV9} ${HEXAGON}			${MIPS32} ${MIPS64} ${S390X} ${SPARC} ${SPARCV9} ${HEXAGON}
	${RISCV32} ${RISCV64})			${RISCV32} ${RISCV64})
	set(ALL_TSAN_SUPPORTED_ARCH ${X86_64} ${MIPS64} ${ARM64} ${PPC64} ${S390X}			set(ALL_TSAN_SUPPORTED_ARCH ${X86_64} ${MIPS64} ${ARM64} ${PPC64} ${S390X}
	${LOONGARCH64})			${LOONGARCH64})
	set(ALL_UBSAN_SUPPORTED_ARCH ${X86} ${X86_64} ${ARM32} ${ARM64} ${RISCV64}			set(ALL_UBSAN_SUPPORTED_ARCH ${X86} ${X86_64} ${ARM32} ${ARM64} ${RISCV64}
	${MIPS32} ${MIPS64} ${PPC64} ${S390X} ${SPARC} ${SPARCV9} ${HEXAGON})			${MIPS32} ${MIPS64} ${PPC64} ${S390X} ${SPARC} ${SPARCV9} ${HEXAGON}
				${LOONGARCH64})
	set(ALL_SAFESTACK_SUPPORTED_ARCH ${X86} ${X86_64} ${ARM64} ${MIPS32} ${MIPS64}			set(ALL_SAFESTACK_SUPPORTED_ARCH ${X86} ${X86_64} ${ARM64} ${MIPS32} ${MIPS64}
	${HEXAGON})			${HEXAGON})
	set(ALL_CFI_SUPPORTED_ARCH ${X86} ${X86_64} ${ARM32} ${ARM64} ${MIPS64}			set(ALL_CFI_SUPPORTED_ARCH ${X86} ${X86_64} ${ARM32} ${ARM64} ${MIPS64}
	${HEXAGON})			${HEXAGON})
	set(ALL_SCUDO_SUPPORTED_ARCH ${X86} ${X86_64} ${ARM32} ${ARM64} ${MIPS32}			set(ALL_SCUDO_SUPPORTED_ARCH ${X86} ${X86_64} ${ARM32} ${ARM64} ${MIPS32}
	${MIPS64} ${PPC64} ${HEXAGON} ${LOONGARCH64})			${MIPS64} ${PPC64} ${HEXAGON} ${LOONGARCH64})
	set(ALL_SCUDO_STANDALONE_SUPPORTED_ARCH ${X86} ${X86_64} ${ARM32} ${ARM64}			set(ALL_SCUDO_STANDALONE_SUPPORTED_ARCH ${X86} ${X86_64} ${ARM32} ${ARM64}
	${MIPS32} ${MIPS64} ${PPC64} ${HEXAGON} ${LOONGARCH64})			${MIPS32} ${MIPS64} ${PPC64} ${HEXAGON} ${LOONGARCH64})
	Show All 15 Lines