Page MenuHomePhabricator

[ELF2] Extract calculation of symbol binding as a separate function.
ClosedPublic

Authored by ikudrin on Oct 20 2015, 12:24 PM.

Diff Detail

Repository
rL LLVM

Event Timeline

ikudrin updated this revision to Diff 37909.Oct 20 2015, 12:24 PM
ikudrin retitled this revision from to [ELF2] Extract calculation of symbol binding as a separate function..
ikudrin updated this object.
ikudrin added a reviewer: rafael.
ikudrin added a project: lld.
ikudrin added a subscriber: llvm-commits.
rafael accepted this revision.Oct 20 2015, 1:06 PM
rafael edited edge metadata.

LGTM

This revision is now accepted and ready to land.Oct 20 2015, 1:06 PM
ruiu accepted this revision.Oct 20 2015, 1:10 PM
ruiu added a reviewer: ruiu.
ruiu added a subscriber: ruiu.

LGTM with a nit.

ELF/OutputSections.cpp
822–823 ↗(On Diff #37909)

unsigned char -> uint8_t

This revision was automatically updated to reflect the committed changes.