This is an archive of the discontinued LLVM Phabricator instance.

[AArch64] Make opcode switch in tryARM64PackedUnwind comprehensive.
ClosedPublic

Authored by efriedma on Nov 30 2022, 2:47 PM.

Details

Summary

I don't think compiler-generated code could actually be affected by this, but better to be thorough.

Diff Detail

Event Timeline

efriedma created this revision.Nov 30 2022, 2:47 PM
Herald added a project: Restricted Project. · View Herald TranscriptNov 30 2022, 2:47 PM
efriedma requested review of this revision.Nov 30 2022, 2:47 PM
Herald added a project: Restricted Project. · View Herald TranscriptNov 30 2022, 2:47 PM
mstorsjo accepted this revision.Nov 30 2022, 10:44 PM

LGTM, thanks!

llvm/lib/MC/MCWin64EH.cpp
1014

In addition to these, there's also UOP_PushMachFrame (which is shared with x86_64) which can be used on arm64, in the same way (only manually generated with custom assembly directives).

The fact that some opcodes are shared between x86_64, arm64 and arm is a bit messy - I guess it would be clearer if they would be entirely separate sets of opcodes without reuse.

This revision is now accepted and ready to land.Nov 30 2022, 10:44 PM