This is an archive of the discontinued LLVM Phabricator instance.

Differential D138985

[AIX][BigArchive][NFC] Add test case that list members of archive with free list in it
ClosedPublic

Authored by lkail on Nov 30 2022, 12:19 AM.

Details

Reviewers
Esme
DiggerLin
Group Reviewers
Restricted Project
Commits
rGbef10bf4e343: [AIX][BigArchive][NFC] Add test case that list members of archive with free…
Summary

The archive is generated via

touch foo.c
ar crus libfoo.a foo.c
ar d libfoo.a foo.c

Thus it contains free list.

Diff Detail

Event Timeline

lkail created this revision.Nov 30 2022, 12:19 AM
Herald added a project: Restricted Project. · View Herald TranscriptNov 30 2022, 12:19 AM
lkail requested review of this revision.Nov 30 2022, 12:19 AM
Herald added a project: Restricted Project. · View Herald TranscriptNov 30 2022, 12:19 AM
Herald added a subscriber: llvm-commits. · View Herald Transcript
lkail added a child revision: D138986: [AIX][BigArchive] Treat the archive is empty if the first child member offset is zero.Nov 30 2022, 12:24 AM
lkail retitled this revision from [BigArchive][NFC] Add test case that list members of archive with free list in it to [AIX][BigArchive][NFC] Add test case that list members of archive with free list in it.Nov 30 2022, 12:27 AM
Harbormaster completed remote builds in B200193: Diff 478831.Nov 30 2022, 1:39 AM
lkail updated this revision to Diff 481541.Dec 9 2022, 12:49 AM
lkail updated this revision to Diff 481549.Dec 9 2022, 1:08 AM
lkail updated this revision to Diff 481550.Dec 9 2022, 1:11 AM
Harbormaster completed remote builds in B202171: Diff 481550.Dec 9 2022, 1:20 AM
lkail updated this revision to Diff 481572.Dec 9 2022, 1:54 AM
Harbormaster completed remote builds in B202180: Diff 481572.Dec 9 2022, 2:52 AM
Esme accepted this revision.Dec 9 2022, 8:41 AM

LGTM. Thx.

This revision is now accepted and ready to land.Dec 9 2022, 8:41 AM
DiggerLin added inline comments.Dec 9 2022, 10:24 AM
llvm/test/Object/archive-big-read-empty-with-freelist.test
3

just curiously, why need to set the "env TZ=GMT"

lkail added inline comments.Dec 11 2022, 5:42 PM
llvm/test/Object/archive-big-read-empty-with-freelist.test
3

Hmmmm, looks we don't need it here since we don't check timestamp in this test. Will update the case.

lkail updated this revision to Diff 481965.Dec 11 2022, 6:20 PM
Harbormaster completed remote builds in B202472: Diff 481965.Dec 11 2022, 7:12 PM
DiggerLin accepted this revision.Dec 12 2022, 6:08 AM

LGTM

This revision was landed with ongoing or failed builds.Dec 15 2022, 7:24 PM
Closed by commit rGbef10bf4e343: [AIX][BigArchive][NFC] Add test case that list members of archive with free… (authored by lkail). · Explain Why
This revision was automatically updated to reflect the committed changes.
lkail added a commit: rGbef10bf4e343: [AIX][BigArchive][NFC] Add test case that list members of archive with free….
lkail removed a child revision: D138986: [AIX][BigArchive] Treat the archive is empty if the first child member offset is zero.Dec 15 2022, 7:25 PM

Revision Contents

Diff 483413

llvm/test/Object/Inputs/aix-empty-big-archive-with-freelist.a

  • This binary file was added.

llvm/test/Object/archive-big-read-empty-with-freelist.test

  • This file was added.
# Test reading an empty archive with free list in it.
# RUN: not llvm-ar tv %p/Inputs/aix-empty-big-archive-with-freelist.a 2>&1 \
# RUN: | grep 'truncated or malformed archive'
DiggerLinUnsubmitted
Not Done
ReplyInline Actions

just curiously, why need to set the "env TZ=GMT"

DiggerLin: just curiously, why need to set the "env TZ=GMT"
lkailAuthorUnsubmitted
Done
ReplyInline Actions

Hmmmm, looks we don't need it here since we don't check timestamp in this test. Will update the case.

lkail: Hmmmm, looks we don't need it here since we don't check timestamp in this test. Will update the…