This is an archive of the discontinued LLVM Phabricator instance.

[flang][test] Adjust Driver/pass-plugin-not-found.f90 error message
ClosedPublic

Authored by ro on Nov 24 2022, 5:51 AM.

Details

Summary

The Driver/pass-plugin-not-found.f90 test FAILs on Solaris since part of the error message differs from what the test expects: Solaris has

error: unable to load plugin 'X.Y': 'Could not load library 'X.Y': ld.so.1: flang-new: X.Y: open failed: No such file or directory'

while the test expects

error: unable to load plugin 'X.Y': 'Could not load library 'X.Y': X.Y: cannot open shared object file: No such file or directory'

The last part is emitted by the system dlerror and is thus unportable. Hopefully the error test itself is the same everywhere.

The following patch adjusts the expected message accordingly.

Tested on x86_64-pc-linux-gnu and amd64-pc-solaris2.11.

Diff Detail

Event Timeline

ro created this revision.Nov 24 2022, 5:51 AM
Herald added a project: Restricted Project. · View Herald TranscriptNov 24 2022, 5:51 AM
ro requested review of this revision.Nov 24 2022, 5:51 AM
awarzynski accepted this revision.Nov 24 2022, 7:08 AM

Thanks a ton for doing this, LGTM!

This revision is now accepted and ready to land.Nov 24 2022, 7:08 AM