[test-suite] Add strings.h header to ClamAV and define _XOPEN_SOURCE=600 on AIX for ClamAV/archie-client.

[amyk]

Summary

The ClamAV and archie-client tests are currently disabled on AIX, and we are now in the process
of re-enabling these tests and resolving the remaining issues.

As Clang now treats -Wimplicit-function-declaration and -Wint-conversion as errors,
ClamAV and archie-client are seen to exhibit error messages related to calls to undeclared functions
and incompatible integer to pointer conversions. To resolve these issues on AIX, we simply need to
include the appropriate headers, which are <strings.h> and <netdb.h>. Although the <netdb.h>
header is already included, the gethostname() function is not visible as we previously defined
_XOPEN_SOURCE=700 on AIX in rT000c7b8d78b12b5cc70ad4e69a4cdb1bab23f74d.
Thus, for ClamAV and archie-client specifically on AIX, we define _XOPEN_SOURCE=600 instead.

[MaskRay]

I think it may be useful to use some comments to annotate source file changes (in case we ever upgrade the libraries, e.g. if it becomes too painful to fix all the portability ourselves), but perhaps other changes don't do the annotation yet.

[hubert.reinterpretcast]

MultiSource/Applications/ClamAV/others.h

29

If this file is included under Windows, I am not sure there is a <strings.h>.
I see other files guarding out header inclusions with ifndef C_WINDOWS.

MultiSource/Applications/ClamAV/shared_cfgparser.c

27

Same comment.

[amyk]

Update the patch to address review comments from @MaskRay and @hubert.reinterpretcast:

• Guard #include <strings.h> with ifndef C_WINDOWS
• Add comments to document the changes I've made

[hubert.reinterpretcast]

LGTM; thanks!

MultiSource/Applications/ClamAV/CMakeLists.txt

set(INPUT
   inputs/rtf-test/docCLAMexe.rtf
   inputs/rtf-test/rtf1.rtf
   inputs/rtf-test/rtf-novirus.rtf
 )
 set(RUN_OPTIONS --debug --exclude-dir .svn --verbose -d%S/dbdir -r ${INPUT})
 if(TARGET_OS STREQUAL "Darwin")
   list(APPEND CPPFLAGS -DC_DARWIN)
 endif()
+# ClamAV utilizes functions from <netdb.h>. However, since _XOPEN_SOURCE=700 is
+# defined globally on AIX, it prevents us from having access to some of the
+# functions that are required within ClamAV. Thus, _XOPEN_SOURCE=600 is defined
+# explicitly for AIX to resolve this issue.
 if(TARGET_OS STREQUAL "AIX")
-  list(APPEND CPPFLAGS -DC_AIX)
+  list(APPEND CPPFLAGS -DC_AIX -D_XOPEN_SOURCE=600)
 endif()
 if(TARGET_OS STREQUAL "IRIX")
   list(APPEND CPPFLAGS -DC_IRIX)
 endif()
 if(TARGET_OS STREQUAL "Cygwin")
   list(APPEND CPPFLAGS -DC_CYGWIN)
 endif()
 if(TARGET_OS STREQUAL "FreeBSD")

MultiSource/Applications/ClamAV/Makefile

 
 
 # -- OS macros --
 #  It is especially important to get this correctly defined for windows.
 
 ifeq ($(TARGET_OS),Darwin)
    CPPFLAGS += -DC_DARWIN
 endif
+# ClamAV utilizes functions from <netdb.h>. However, since _XOPEN_SOURCE=700 is
+# defined globally on AIX, it prevents us from having access to some of the
+# functions that are required within ClamAV. Thus, _XOPEN_SOURCE=600 is defined
+# explicitly for AIX to resolve this issue.
 ifeq ($(TARGET_OS),AIX)
-   CPPFLAGS += -DC_AIX
+   CPPFLAGS += -DC_AIX -D_XOPEN_SOURCE=600
 endif
 ifeq ($(TARGET_OS), IRIX)
    CPPFLAGS += -DC_IRIX
 endif
 ifeq ($(TARGET_OS), Cygwin)
    CPPFLAGS += -DC_CYGWIN
 endif
 ifeq ($(TARGET_OS), FreeBSD)

MultiSource/Applications/ClamAV/others.h

 
 #if HAVE_CONFIG_H
 #include "clamav-config.h"
 #endif
 
 #include <stdio.h>
 #include <stdlib.h>
 #include <string.h>
+// This header is required to prevent build failures coming from
+// -Wimplicit-function-declaration with the strcasecmp function.
+// The failures were first seen on AIX.
+#ifndef C_WINDOWS
+#include <strings.h>
+#endif
 #include "cltypes.h"
 
 #include "clamav.h"
 #include "dconf.h"
 
 extern uint8_t cli_debug_flag, cli_leavetemps_flag;
 
 /*

MultiSource/Applications/ClamAV/shared_cfgparser.c

 
 #if HAVE_CONFIG_H
 #include "clamav-config.h"
 #endif
 
 #include <stdio.h>
 #include <stdlib.h>
 #include <string.h>
+#ifndef C_WINDOWS
+// This header is required to prevent build failures coming from
+// -Wimplicit-function-declaration with the strcasecmp function.
+// The failures were first seen on AIX.
+#include <strings.h>
+#endif
 #include <ctype.h>
 
 #include "cfgparser.h"
 #include "misc.h"
 
 #include "str.h"
 
 struct cfgoption cfg_options[] = {

MultiSource/Benchmarks/Prolangs-C/archie-client/CMakeLists.txt

 include(CheckFunctionExists)
 list(APPEND CFLAGS -Wno-implicit-function-declaration)
 list(APPEND CXXFLAGS -Wno-implicit-function-declaration)
 check_function_exists(re_comp HAVE_RE_COMP)
 
+# archie-client utilizes functions from <netdb.h>. However, since
+# _XOPEN_SOURCE=700 is defined globally on AIX, it prevents us from having
+# access to some of the functions that are required within archie-client.
+# Thus, _XOPEN_SOURCE=600 is defined explicitly for AIX to resolve this issue.
+if(TARGET_OS STREQUAL "AIX")
+  list(APPEND CFLAGS -D_XOPEN_SOURCE=600)
+  list(APPEND CXXFLAGS -D_XOPEN_SOURCE=600)
+endif()
+
 if(HAVE_RE_COMP)
   if(TARGET_OS STREQUAL "SunOS")
     list(APPEND LDFLAGS -lsocket -lnsl)
   endif()
   llvm_multisource(archie)
   target_include_directories(archie PRIVATE ${CMAKE_CURRENT_SOURCE_DIR})
 endif()

MultiSource/Benchmarks/Prolangs-C/archie-client/Makefile

 PROG = archie
 endif
 
 include $(LEVEL)/MultiSource/Makefile.multisrc
 
 ifeq ($(TARGET_OS),SunOS)
 LDFLAGS += -lsocket -lnsl
 endif
+
+# archie-client utilizes functions from <netdb.h>. However, since
+# _XOPEN_SOURCE=700 is defined globally on AIX, it prevents us from having
+# access to some of the functions that are required within archie-client.
+# Thus, _XOPEN_SOURCE=600 is defined explicitly for AIX to resolve this issue.
+ifeq ($(TARGET_OS),AIX)
+CFLAGS += -D_XOPEN_SOURCE=600
+CXXFLAGS += -D_XOPEN_SOURCE=600
+endif