This is an archive of the discontinued LLVM Phabricator instance.

Differential D138548

[BOLT] Remove MSVC builder
ClosedPublic

Authored by Amir on Nov 23 2022, 12:54 AM.

Details

Reviewers
gkistanova
Group Reviewers
Restricted Project
Commits
rZORGee07c2105df7: [BOLT] Remove MSVC builder
Summary

MSVC builder takes the longest and doesn't provide clear value to us right now.
Because of it, the other builds are throttled for 30+ mins.
Remove it for now.

Diff Detail

Event Timeline

Amir created this revision.Nov 23 2022, 12:54 AM
Herald added a reviewer: gkistanova. · View Herald TranscriptNov 23 2022, 12:54 AM
Herald added a project: Restricted Project. · View Herald Transcript
Herald added a subscriber: treapster. · View Herald Transcript
Amir requested review of this revision.Nov 23 2022, 12:54 AM
Harbormaster completed remote builds in B199128: Diff 477405.Nov 23 2022, 12:54 AM
Amir accepted this revision as: Restricted Project.Nov 29 2022, 8:23 PM
Amir added a subscriber: maksfb.

Got a verbal approval from @maksfb

This revision was not accepted when it landed; it landed in state Needs Review.Nov 29 2022, 8:23 PM
Closed by commit rZORGee07c2105df7: [BOLT] Remove MSVC builder (authored by Amir). · Explain Why
This revision was automatically updated to reflect the committed changes.
Amir added a commit: rZORGee07c2105df7: [BOLT] Remove MSVC builder.

Revision Contents

PathSize
buildbot/
osuosl/
master/
config/
23 lines

Diff 477405

buildbot/osuosl/master/config/builders.py

Show First 20 Lines • Show All 2,552 Lines • ▼ Show 20 Lines 'factory' : BOLTBuilder.getBOLTCmakeBuildFactory(
"-DLLVM_TARGETS_TO_BUILD=X86;AArch64", "-DLLVM_TARGETS_TO_BUILD=X86;AArch64",
"-DBUILD_SHARED_LIBS=ON", "-DBUILD_SHARED_LIBS=ON",
"-DLLVM_ENABLE_LLD=ON", "-DLLVM_ENABLE_LLD=ON",
"-DBOLT_CLANG_EXE=/usr/bin/clang", "-DBOLT_CLANG_EXE=/usr/bin/clang",
"-DBOLT_LLD_EXE=/usr/bin/ld.lld", "-DBOLT_LLD_EXE=/usr/bin/ld.lld",
], ],
)}, )},
{'name' : "bolt-x86_64-wine-msvc",
'tags' : ["bolt"],
'collapseRequests': True,
'workernames' : ["bolt-worker"],
'builddir': "bolt-x86_64-wine-msvc",
'factory' : UnifiedTreeBuilder.getCmakeWithNinjaBuildFactory(
targets = ['bolt'],
checks = [],
depends_on_projects=['llvm','bolt'],
extra_configure_args=[
"-DCMAKE_C_COMPILER=cl",
"-DCMAKE_CXX_COMPILER=cl",
"-DCMAKE_SYSTEM_NAME=Windows",
"-DLLVM_APPEND_VC_REV=OFF",
"-DLLVM_CCACHE_BUILD=ON",
"-DLLVM_ENABLE_PROJECTS=bolt",
"-DLLVM_TARGETS_TO_BUILD=X86;AArch64",
"-DLLVM_OPTIMIZED_TABLEGEN=ON",
],
env={
'PATH':'/home/worker/msvc-wine/cmake/bin:/home/worker/msvc-wine/msvc/bin/x64:/usr/bin:/bin',
})},
# AMD ROCm support. # AMD ROCm support.
{'name' : 'mlir-rocm-mi200', {'name' : 'mlir-rocm-mi200',
'tags' : ["mlir"], 'tags' : ["mlir"],
'collapseRequests' : False, 'collapseRequests' : False,
'workernames' : ['mi200-buildbot'], 'workernames' : ['mi200-buildbot'],
'builddir': 'mlir-rocm-mi200', 'builddir': 'mlir-rocm-mi200',
'factory' : UnifiedTreeBuilder.getCmakeWithNinjaBuildFactory( 'factory' : UnifiedTreeBuilder.getCmakeWithNinjaBuildFactory(
clean=True, clean=True,
▲ Show 20 Lines • Show All 149 Lines • Show Last 20 Lines