This is an archive of the discontinued LLVM Phabricator instance.

[DirectX] Fix build after 7059a6c32cfad8f272fad47265e3890cd7a1a7e1
AbandonedPublic

Authored by arichardson on Nov 21 2022, 6:46 AM.

Details

Diff Detail

Event Timeline

arichardson created this revision.Nov 21 2022, 6:46 AM
Herald added a project: Restricted Project. · View Herald TranscriptNov 21 2022, 6:46 AM
Herald added a subscriber: hiraditya. · View Herald Transcript
arichardson requested review of this revision.Nov 21 2022, 6:46 AM
Herald added a project: Restricted Project. · View Herald TranscriptNov 21 2022, 6:46 AM

ping? Almost certain this is the correct fix, just opened this revision to confirm. If I don't hear back by end of week I'll go ahead and commit it.

Thanks for the fix,
if i understand correctly this is yet another place that uses the legacy pass manager and createPrintModulePass(....) - right ?

llvm/lib/Target/DirectX/DirectXTargetMachine.cpp
27

nit: can this include be removed ?

This revision is now accepted and ready to land.Nov 29 2022, 9:43 AM
arichardson abandoned this revision.Dec 1 2022, 8:53 AM

Looks like it was already fixexd in 8f0cd7c1d0af6484eb75369a231408649bb0ce88