This is an archive of the discontinued LLVM Phabricator instance.

[DirectX] Fix shared libraries build
ClosedPublic

Authored by arichardson on Nov 21 2022, 6:45 AM.

Details

Summary

I just tried to build all experimental targets and noticed that DirectX did
not build with -DBUILD_SHARED_LIBS=ON.

Diff Detail

Event Timeline

arichardson created this revision.Nov 21 2022, 6:45 AM
Herald added a project: Restricted Project. · View Herald TranscriptNov 21 2022, 6:45 AM
Herald added a subscriber: hiraditya. · View Herald Transcript
arichardson requested review of this revision.Nov 21 2022, 6:45 AM
Herald added a project: Restricted Project. · View Herald TranscriptNov 21 2022, 6:45 AM
beanz added a comment.Nov 21 2022, 9:44 AM

I think I would broadly classify that there are two problems you're fixing here:
(1) Under-specified dependencies.
(2) A cyclic dependency on PointerTypeAnalysis

I agree with how you've addressed (1), I think breaking PointerTypeAnalysis into its own library is less than ideal.

We have a growing set of IR passes in the DirectX backend, and I expect that number of passes to keep growing for a while. It probably just makes more sense to create a DirectXIRPasses library and move PointerTypeAnalysis to that library.

I don't want to push you to clean up all our code organization in order to fix the bug you're working on. If you change the PointerTypeAnalysis library name to DirectXIRPasses I'll approve this and finish the code reorganization when I get a chance in a week or two.

Thanks!

address review feedback

This revision was not accepted when it landed; it landed in state Needs Review.Dec 1 2022, 8:54 AM
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.